SG-40994 Update Python 3.7 EOL banner to announce breaking changes #206
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Python 3.7 end-of-life notification banner to announce upcoming breaking changes. The notification ID is changed to reflect that this is now about breaking changes rather than just deprecation, and the messaging is updated to reflect new timelines and version requirements (March 2026 deadline, Python 3.11 recommended).
Key changes:
- Updated notification ID from "deprecation-notification-python37" to "python37-breaking-changes"
- Changed messaging from February 2025 deadline to March 2026 with breaking changes emphasis
- Updated recommended Python version from 3.9+ to 3.11
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
python/tk_desktop/notifications/python37_deprecation_notification.py
Outdated
Show resolved
Hide resolved
mchesnay
left a comment
mchesnay
left a comment
There was a problem hiding this comment.
Comments to address before merging. As stated in Slack, I'm not comfortable being the sole reviewer on this: a PM should be in the loop and approve the text.
Also, could the date be March 31 or April 2? That change happening on April 1 (April's fool day) could be an issue
python/tk_desktop/notifications/python37_deprecation_notification.py
Outdated
Show resolved
Hide resolved
python/tk_desktop/notifications/python37_deprecation_notification.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Chesnay <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
python/tk_desktop/notifications/python37_deprecation_notification.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Related to shotgunsoftware/tk-core#1069
Follow up from #180
New banner: