[Feat]: Support Lora Weight #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What other stuff do you think needs to be added to X-Adapter? I am suspect they might not be updating this again |
Author
|
I also think my PR might not get merged at this point. Other than that, I don't think I have anything additional to add yet. I included it because, in many cases, lowering the LoRA weight slightly results in images that look better and don't break. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR takes the lora weight values and scales the learned weights of lora. The reason these weight values are needed is that some LoRA models require weight values lower than 1 to ensure the images do not break and are properly rendered. Adjusting the adapter_condition_scale value was not a solution.