Repository navigation
fix(pi): retain Linux process name alongside launch arguments - #3424
Merged
Merged
Conversation
|
Warning This organization is out of credits, so Indent couldn't continue this review. Manage billing to resume reviews on this repository.
All required CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
shunkakinoki
marked this pull request as ready for review
November 16, 2026 00:49
Contributor
|
This run was cancelled before it finished. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Tracker linkage
Relates to SHUN-43195
The Linux argument-preservation patch kept Pi’s title changes only in JavaScript. Supervisors could read the model arguments again, but process-name-based detection saw
MainThreadinstead ofpiand reported the ready process as unknown.Set the Linux process name through
/proc/self/commwhile preserving the original kernel argument vector. This retains both supervisor detection and exact model/mode/session verification. Other platforms retain upstream behavior.MainThreadpiValidation: all 17 affected tests pass, including the real Node regression checking both kernel argv and process name after repeated renaming. Clean and frozen managed package installs pass. The official patched Pi 1.5.2 interactive TUI reaches Fleet prompt ready with kernel name
piand an exact full argument-vector match; the fixture submits no prompt and consumes no model request.decided: preserve the operating-system name as well as arguments because both are consumed by supervisors. Exact target verification remains unchanged.
Summary by cubic
Fixes Pi's Linux process name showing
MainThreadinstead ofpiafter the argument-preservation patch: the process name is now written to/proc/self/commwhile the kernel argv is left unchanged, so supervisors can detect the ready process by name and verify the exact model/mode/session arguments. The native argv regression test now asserts the process name alongside the preserved arguments, and other platforms retain upstream behavior.Written for commit 75fce44. Summary will update on new commits.