Skip to content

fix(pi): retain Linux process name alongside launch arguments - #3424

Merged
shunkakinoki merged 1 commit into
mainfrom
fix/pi-native-name-and-argv
Nov 16, 2026
Merged

shunkakinoki merged 1 commit into
mainfrom
fix/pi-native-name-and-argv

Conversation

@shunkakinoki

@shunkakinoki shunkakinoki commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Written by an AI agent at the operator’s direction. The operator has not reviewed it yet.

Tracker linkage

  • Linear: SHUN-43195

Relates to SHUN-43195

The Linux argument-preservation patch kept Pi’s title changes only in JavaScript. Supervisors could read the model arguments again, but process-name-based detection saw MainThread instead of pi and reported the ready process as unknown.

Set the Linux process name through /proc/self/comm while preserving the original kernel argument vector. This retains both supervisor detection and exact model/mode/session verification. Other platforms retain upstream behavior.

Before After
Complete launch arguments, process name MainThread Complete launch arguments, process name pi
Ready interactive process is unknown to supervisor Native process name and target arguments are both observable

Validation: all 17 affected tests pass, including the real Node regression checking both kernel argv and process name after repeated renaming. Clean and frozen managed package installs pass. The official patched Pi 1.5.2 interactive TUI reaches Fleet prompt ready with kernel name pi and an exact full argument-vector match; the fixture submits no prompt and consumes no model request.

decided: preserve the operating-system name as well as arguments because both are consumed by supervisors. Exact target verification remains unchanged.


Summary by cubic

Fixes Pi's Linux process name showing MainThread instead of pi after the argument-preservation patch: the process name is now written to /proc/self/comm while the kernel argv is left unchanged, so supervisors can detect the ready process by name and verify the exact model/mode/session arguments. The native argv regression test now asserts the process name alongside the preserved arguments, and other platforms retain upstream behavior.

Written for commit 75fce44. Summary will update on new commits.

View guided diff Turn on auto-fix

@linear-code

linear-code Bot commented Nov 16, 2026

Copy link
Copy Markdown

SHUN-43195

@indent

indent Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Warning

This organization is out of credits, so Indent couldn't continue this review. Manage billing to resume reviews on this repository.

CI Checks

All required CI checks passed on 75fce44.

Review agents

Select any unchecked box below to run or rerun that agent.

Pending (1)
  • Indent Review Agent · This agent has not run.
Full results

Indent Review Agent

  • Summary: This agent has not run.
  • Latest resultNo result — this agent has not run.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@shunkakinoki
shunkakinoki marked this pull request as ready for review November 16, 2026 00:49
@pullfrog

pullfrog Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

This run was cancelled before it finished.

Pullfrog  | View workflow run | via Pullfrog

@shunkakinoki
shunkakinoki merged commit db9d235 into main Nov 16, 2026
17 of 18 checks passed
@shunkakinoki
shunkakinoki deleted the fix/pi-native-name-and-argv branch November 16, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant