Hide JSON tab with IP addresses when BTCEXP_HIDE_IP=true#198
Open
infertux wants to merge 1 commit intosickpig:masterfrom
Open
Hide JSON tab with IP addresses when BTCEXP_HIDE_IP=true#198infertux wants to merge 1 commit intosickpig:masterfrom
infertux wants to merge 1 commit intosickpig:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even with
BTCEXP_HIDE_IP=true(default config), all the IP addresses of the node are visible on the "Node Status" JSON tab. This can be seen at https://explorer.electroncash.de/node-status for instance. Even though the IPs are hidden in the "Details" tab, they are visible in the "JSON" tab.This PR hides the "JSON" tab altogether, another approach might be to hide just the sub-tab
tab-getnetworkinfo. I could edit the PR if you'd rather do that.