Show in progress spinner after phone number is confirmed in EnterPhoneNumberFragment

[clauz9]

First time contributor checklist

• I have read how to contribute to this project
• I have signed the Contributor License Agreement

Contributor checklist

• I am following the Code Style Guidelines
• I have tested my contribution on these devices:

• Samsung A14, Android 13
• Nokia 3.1, Android 10

• My contribution is fully baked and ready to be merged as is
• I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

---

Description

Current behavior of the continue/progress button, in EnterPhoneNumberFragment makes for a confusing user experience.

GIF Recording Before changes

after you confirm the phone number, the spinner is canceled, and the user is left with an active "Continue" button, and no indication that something is happening in the background.

the spinner is cancelled by this call to exitInProgressUiState() on line 473

Signal-Android/app/src/main/java/org/thoughtcrime/securesms/registration/fragments/EnterPhoneNumberFragment.java

Lines 466 to 480 in 98424f6

	.subscribe(canSkipSms -> showConfirmNumberDialogIfTranslated(context,
	viewModel.hasUserSkippedReRegisterFlow() ? R.string.RegistrationActivity_additional_verification_required
	: R.string.RegistrationActivity_phone_number_verification_dialog_title,
	canSkipSms ? null
	: R.string.RegistrationActivity_a_verification_code_will_be_sent_to_this_number,
	e164number,
	() -> {
	exitInProgressUiState();
	ViewUtil.hideKeyboard(context, number.getEditText());
	onConfirmed.run();
	},
	() -> {
	exitInProgressUiState();
	ViewUtil.focusAndMoveCursorToEndAndOpenKeyboard(this.number.getEditText());
	}))

And also, it will be canceled by the use of the onDismissListener() in showConfirmNumberDialogIfTranslated()

Signal-Android/app/src/main/java/org/thoughtcrime/securesms/registration/fragments/RegistrationViewDelegate.kt

Line 61 in 98424f6

setOnDismissListener { onEditNumber.run() }

which according to the docs is called for any reason, if the dialog is dismissed.

So I changed it with setOnCancelListener() which gets called, when you cancel the dialog, this includes tapping outside the dialog

This is the behavior after the change..

GIF Recording after changed

[clauz9]

This got fixed here e1570e9

Edit: Not entirely....

[clauz9]

It turns out this change, e1570e9 causes an issue with the missing play services dialog

Screenshot

Because this line

Signal-Android/app/src/main/java/org/thoughtcrime/securesms/registration/fragments/EnterPhoneNumberFragment.java

Line 461 in 47673be

enterInProgressUiState();

starts the spinning animation as soon as the confirmNumberPrompt is displayed,
and since the missing play services dialog is displayed after that, if you dismiss it, at that point, the user is stuck on the EnterPhoneNumberFragment with a spinning circle animation, instead of a continue button

Deleting that line, ensures that the only start point for the circle animation is here.

Signal-Android/app/src/main/java/org/thoughtcrime/securesms/registration/fragments/EnterPhoneNumberFragment.java

Lines 205 to 221 in 47673be

	private void onE164EnteredSuccessfully(@NonNull Context context, boolean fcmSupported) {
	enterInProgressUiState();
	Disposable disposable = viewModel.canEnterSkipSmsFlow()
	.observeOn(AndroidSchedulers.mainThread())
	.onErrorReturnItem(false)
	.subscribe(canEnter -> {
	if (canEnter) {
	Log.i(TAG, "Enter skip flow");
	SafeNavigation.safeNavigate(NavHostFragment.findNavController(this), EnterPhoneNumberFragmentDirections.actionReRegisterWithPinFragment());
	} else {
	Log.i(TAG, "Unable to collect necessary data to enter skip flow, returning to normal");
	handleRequestVerification(context, fcmSupported);
	}
	});
	disposables.add(disposable);
	}