Clamped Disppearing Messages to 4 Weeks #5965
Open
+15
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rval is weeks. (cherry picked from commit 8908f61a989f0b3a1c454353c13fe97ac1222913)
3 tasks
(cherry picked from commit 87cdde7309f1aed437e14ac4cbef391c15c63404)
|
Hi @MarlowBrown, While I'm guessing this workaround works for the specific case of handling too-many weeks, it feels like we shouldn't need to be clamping. Instead, it feels like when the unit is changed (e.g., from days to weeks), and the maximum selectable number of units is clamped in the UI (e.g., from some number of days to "4", for weeks), that the new "selected" unit should be propagated back to the view controller by the |
(cherry picked from commit a58de504321a8dcea510db1b71596eb16d38aa49)
|
Update for you @sashaweiss-signal I changed the code to avoid clamping. The change is a little weird as technically until the user has moved the picker wheel, it doesn't count as "selected". I think it might be by design, so the code for force selecting is warranted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Description
This pull request
fixes #5947by clamping an internal value in the Disappearing Messages Timers picker to 4 weeks.