Skip to content

Conversation

@JWinermaSplunk
Copy link
Contributor

add makefile and lint recipe to auto resolve linting failures

@JWinermaSplunk JWinermaSplunk requested review from a team as code owners December 5, 2025 22:21
@keith-decker
Copy link
Contributor

Could we add this to a pre-commit hook, similar to how the python-contrib repo does?

https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/.pre-commit-config.yaml

That way running pip install pre-commit -c dev-requirements.txt && pre-commit install as part of your cloning of the repo will run the ruff before committing

@JWinermaSplunk
Copy link
Contributor Author

@keith-decker

funny enough, we already have a pre-commit-config set up, so I went ahead and updated the README for that and removed the Makefile.

@JWinermaSplunk
Copy link
Contributor Author

@keith-decker

On second thought, would it be best to still include the make recipe as well as the pre-commit hook only applies to staged files? Might be helpful if someone made commits without having pre-commit configured before hand, but could also lead to excess for the commit history of a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants