Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-duplicate enable_light_client_server #6988

Open
wants to merge 3 commits into
base: unstable
Choose a base branch
from
Open

De-duplicate enable_light_client_server #6988

wants to merge 3 commits into from

Conversation

EllipticPoint
Copy link
Member

Issue Addressed

#6959

Proposed Changes

  • Use Arc<bool> type to create a single source of truth
  • A new field enable_light_client_server: Arc<bool> has been added to Config.
  • The 3 existing struct fields mentioned in the issue have been changed to Arc<bool>

@EllipticPoint EllipticPoint requested a review from jxs as a code owner February 11, 2025 23:39
@CLAassistant
Copy link

CLAassistant commented Feb 11, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mergify Mergify
Copy link

mergify bot commented Feb 11, 2025

This pull request has merge conflicts. Could you please resolve them @EllipticPoint? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs Awaiting requested review from jxs jxs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EllipticPoint @CLAassistant