Remove context_deserialize and import from crates.io
#8172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts. Could you please resolve them @macladson? 🙏 |
mergify
bot
added
waiting-on-author
|
Some required checks have failed. Could you please take a look @macladson? 🙏 |
macladson
force-pushed
the
remove-context-deserialize
branch
from
072e297 to
fac493f
Compare
mergify
bot
added
ready-for-review
|
Some required checks have failed. Could you please take a look @macladson? 🙏 |
mergify
bot
added
waiting-on-author
mergify
bot
added
ready-for-review
Member
Author
|
All deps have been bumped and this is ready to go now! |
michaelsproul
requested changes
Nov 27, 2025
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
Needs a bump on ethereum_hashing (see above)
michaelsproul
added
the
waiting-on-author
macladson
removed
the
waiting-on-author
michaelsproul
approved these changes
Nov 27, 2025
michaelsproul
added
ready-for-merge
Merge Queue Status
✅ The pull request has been merged This pull request spent 1 hour 4 minutes 24 seconds in the queue, including 31 minutes 52 seconds waiting for CI. Required conditions to merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Use the recently published
context_deserializeand remove it from LighthouseAdditional Info
While we can technically merge this, I am going to keep this blocked until I have pushed a new version of
context_deserializeto remove impls on foreign types (ssz_types,milhouse, etc) and implemented it in those crates instead. This will reduce ongoing maintenance since we will not have to continually bump the deps incontext_deserialize.