Skip to content

Fix testnet script #8557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 8 commits into from
Dec 11, 2025
Merged

Fix testnet script #8557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3d40e71
fix network_params.yml testnet script
eserilev Dec 9, 2025
92206ec
Fix testnet script
eserilev Dec 9, 2025
769ec79
rerun
eserilev Dec 9, 2025
dd5ae5b
rerun
eserilev Dec 9, 2025
2160e84
Fix
eserilev Dec 9, 2025
abe4fb7
hmm
eserilev Dec 9, 2025
1ac711d
update
eserilev Dec 9, 2025
d9c65c9
Be explicit about fulu_fork_epoch
pawanjay176 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions scripts/tests/genesis-sync-config-electra.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,14 @@ participants:
# nodes without validators, used for testing sync.
- cl_type: lighthouse
cl_image: lighthouse:local
supernode: true # no supernode in Electra, this is for future proof
Copy link
Member Author

@eserilev eserilev Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at the logs for electra genesis sync tests I'm seeing references to data columns

Dec 09 19:30:14.084 DEBUG Successfully verified gossip data column sidecar  slot: 5, block_root: 0xba943c4877f4edf35acdfba341e56e8472e45da4ae1a3cc3dc04316aa1e6568b, index: 3
Dec 09 19:30:14.087 DEBUG Successfully verified gossip data column sidecar  slot: 5, block_root: 0xba943c4877f4edf35acdfba341e56e8472e45da4ae1a3cc3dc04316aa1e6568b, index: 5
Dec 09 19:30:14.088 DEBUG Successfully verified gossip data column sidecar  slot: 5, block_root: 0xba943c4877f4edf35acdfba341e56e8472e45da4ae1a3cc3dc04316aa1e6568b, index: 0
Dec 09 19:30:14.089 DEBUG Successfully verified gossip data column sidecar  slot: 5, block_root: 0xba943c4877f4edf35acdfba341e56e8472e45da4ae1a3cc3dc04316aa1e6568b, index: 4
Dec 09 19:30:14.092 DEBUG Successfully verified gossip data column sidecar  slot: 5, block_root: 0xba943c4877f4edf35acdfba341e56e8472e45da4ae1a3cc3dc04316aa1e6568b, index: 6
Dec 09 19:30:14.092 DEBUG Successfully verified gossip data column sidecar  slot: 5, block_root: 0xba943c4877f4edf35acdfba341e56e8472e45da4ae1a3cc3dc04316aa1e6568b, index: 2
Dec 09 19:30:14.093 DEBUG Successfully verified gossip data column sidecar  slot: 5, block_root: 0xba943c4877f4edf35acdfba341e56e8472e45da4ae1a3cc3dc04316aa1e6568b, index: 1
Dec 09 19:30:14.096 DEBUG Successfully verified gossip data column sidecar  slot: 5, block_root: 0xba943c4877f4edf35acdfba341e56e8472e45da4ae1a3cc3dc04316aa1e6568b, index: 8

maybe something weird going on with the supernode flag?

Copy link
Member Author

@eserilev eserilev Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fulu is being set by default, so i defined the fulu fork epoch to be way in the future. we dont need these supernode flags either way

validator_count: 0
- cl_type: lighthouse
cl_image: lighthouse:local
supernode: false
validator_count: 0
network_params:
seconds_per_slot: 6
electra_fork_epoch: 0
fulu_fork_epoch: 100000 # a really big number so this test stays in electra
preset: "minimal"
additional_services:
- tx_fuzz
Expand Down
3 changes: 1 addition & 2 deletions scripts/tests/genesis-sync-config-fulu.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ participants:
validator_count: 0
network_params:
seconds_per_slot: 6
electra_fork_epoch: 0
fulu_fork_epoch: 1
fulu_fork_epoch: 0
Copy link
Member Author

@eserilev eserilev Dec 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes this error

Evaluation error: fail: Fulu fork must happen before BPO 1, please adjust the epochs accordingly.
	at [github.com/ethpandaops/ethereum-package/main.star:83:57]: run
	at [github.com/ethpandaops/ethereum-package/src/package_io/input_parser.star:345:13]: input_parser
	at [0:0]: fail

also no need to start at electra anymore anyways, as fulu at genesis is supported

Copy link
Member

@pawanjay176 pawanjay176 Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realise we support fulu genesis now. Very cool

preset: "minimal"
additional_services:
- tx_fuzz
Expand Down
3 changes: 2 additions & 1 deletion scripts/tests/network_params.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@ participants:
cl_image: lighthouse:local
cl_extra_params:
- --target-peers=3
supernode: true
Copy link
Member Author

@eserilev eserilev Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need at least one supernode configured or kurtosis complains

count: 4
network_params:
electra_fork_epoch: 0
fulu_fork_epoch: 0
seconds_per_slot: 3
num_validator_keys_per_node: 20
global_log_level: debug
Expand Down