Skip to content

Conversation

@ackintosh
Copy link
Member

Apologies for the small PR, this only tweaks a log message. 😅

Issue Addressed

$ lcli mock-el ....
...
...
Dec 15 11:52:06.002 INFO  Metrics HTTP server started                   listen_address: "127.0.0.1:8551"
...

The log message "Metrics HTTP server" was misleading, as the server is actually a Mock Execution Client that provides a JSON-RPC API for testing purposes, not a metrics server.

@ackintosh ackintosh added ready-for-review The code is ready for review UX-and-logs labels Dec 18, 2025
Copy link
Member

@chong-he chong-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually just the first letter is capitalized in the log but it doesn't really matter though

@pawanjay176 pawanjay176 added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 7, 2026
@mergify mergify bot added the queued label Jan 7, 2026
@mergify
Copy link

mergify bot commented Jan 7, 2026

Merge Queue Status

✅ The pull request has been merged at 7cdc7d1

This pull request spent 39 minutes 54 seconds in the queue, including 38 minutes 5 seconds running CI.
The checks were run on draft #8632.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

mergify bot added a commit that referenced this pull request Jan 7, 2026
@mergify mergify bot merged commit 79d314d into sigp:unstable Jan 7, 2026
36 checks passed
@mergify mergify bot removed the queued label Jan 7, 2026
@ackintosh ackintosh deleted the log-mock-el branch January 7, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge This PR is ready to merge. UX-and-logs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants