Skip to content

Add rest of missing specs to spec api #8613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xmrree wants to merge 3 commits into
base: unstable
Choose a base branch
from
Open

Add rest of missing specs to spec api #8613

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a87865
feat: added timing specs to api
0xmrree Dec 29, 2025
deef3a8
unit tests
0xmrree Dec 29, 2025
6f29af7
nit: format
0xmrree Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions consensus/types/src/core/config_and_preset.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,13 @@ pub fn get_extra_fields(spec: &ChainSpec) -> HashMap<String, Value> {
"compounding_withdrawal_prefix".to_uppercase() => u8_hex(spec.compounding_withdrawal_prefix_byte),
"unset_deposit_requests_start_index".to_uppercase() => spec.unset_deposit_requests_start_index.to_string().into(),
"full_exit_request_amount".to_uppercase() => spec.full_exit_request_amount.to_string().into(),
// Time parameters
"slot_duration_ms".to_uppercase() => spec.slot_duration_ms.to_string().into(),
"proposer_reorg_cutoff_bps".to_uppercase() => spec.proposer_reorg_cutoff_bps.to_string().into(),
"attestation_due_bps".to_uppercase() => spec.attestation_due_bps.to_string().into(),
"aggregate_due_bps".to_uppercase() => spec.aggregate_due_bps.to_string().into(),
"contribution_due_bps".to_uppercase() => spec.contribution_due_bps.to_string().into(),
"sync_message_due_bps".to_uppercase() => spec.sync_message_due_bps.to_string().into(),
}
}

Expand Down Expand Up @@ -183,4 +190,24 @@ mod test {
serde_yaml::from_reader(reader).expect("error while deserializing");
assert_eq!(ConfigAndPreset::Gloas(from), yamlconfig);
}

// This is not exhaustive, but it can be extended as new fields are added to the spec.
#[test]
fn test_required_spec_fields_exist() {
let mainnet_spec = ChainSpec::mainnet();
let config = ConfigAndPreset::from_chain_spec::<MainnetEthSpec>(&mainnet_spec);
let json = serde_json::to_value(&config).expect("should serialize");
let obj = json.as_object().expect("should be an object");
let required_fields = [
"SLOT_DURATION_MS",
"PROPOSER_REORG_CUTOFF_BPS",
"ATTESTATION_DUE_BPS",
"AGGREGATE_DUE_BPS",
"CONTRIBUTION_DUE_BPS",
"SYNC_MESSAGE_DUE_BPS",
];
for field in required_fields {
assert!(obj.contains_key(field), "Missing required field: {}", field);
}
}
}