-
Notifications
You must be signed in to change notification settings - Fork 957
perf: remove allocations from merkle tree proof verification logic #8614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
commented
Dec 29, 2025
kevaundray
commented
Dec 29, 2025
michaelsproul
approved these changes
Jan 2, 2026
Member
michaelsproul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, nice improvement thanks!
jimmygchen
approved these changes
Jan 5, 2026
Merge Queue Status✅ The pull request has been merged at 3b97964 This pull request spent 37 minutes 31 seconds in the queue, including 36 minutes 9 seconds running CI. Required conditions to merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
consensus
An issue/PR that touches consensus code, such as state_processing or block verification.
crypto
An issue/PR that touches cryptography code.
optimization
Something to make Lighthouse run more efficiently.
ready-for-merge
This PR is ready to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
This PR does two small things:
Additional Info
Benchmarked on Apple M4 Max and there is a 33% performance increase, which concretely amounted to ~1.2 microseconds savings for depth=32.
Not a lot, so I think the main performance benefit would be the reduction in possible allocations that would have happened during the for loop.