Skip to content

Conversation

@chong-he
Copy link
Member

@chong-he chong-he commented Jan 6, 2026

Remove most of the mention of Windows OS where unnecessary, and added a note about Windows build from source

@chong-he chong-he added ready-for-review The code is ready for review docs Documentation labels Jan 6, 2026
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth updating these too? Perhaps adding a asterisk / or a brief mention there that it's no longer officially supported?

Lighthouse runs on Linux, macOS, and Windows.

Lighthouse builds on Linux, macOS, and Windows. Install the [Dependencies](#dependencies) using

@chong-he
Copy link
Member Author

chong-he commented Jan 6, 2026

Is it worth updating these too? Perhaps adding a asterisk / or a brief mention there that it's no longer officially supported?

Lighthouse runs on Linux, macOS, and Windows.

Lighthouse builds on Linux, macOS, and Windows. Install the [Dependencies](#dependencies) using

These are the parts that I left it as it is as it still runs on Windows, but yeah I will add a note here too

Edit: added a note in lighthouse/book/src/installation.md, leave installation_source.md there as there is another note about Windows build in the same file

Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 8, 2026
@mergify mergify bot added the queued label Jan 8, 2026
@mergify
Copy link

mergify bot commented Jan 8, 2026

Merge Queue Status

✅ The pull request has been merged at 113cfdc

This pull request spent 39 minutes 16 seconds in the queue, including 37 minutes running CI.
The checks were run on draft #8635.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

mergify bot added a commit that referenced this pull request Jan 8, 2026
@mergify mergify bot merged commit a39558f into sigp:unstable Jan 8, 2026
37 checks passed
@mergify mergify bot removed the queued label Jan 8, 2026
@chong-he chong-he deleted the remove-windows branch January 8, 2026 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants