-
Notifications
You must be signed in to change notification settings - Fork 957
Remove Windows in the documentation #8628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jimmygchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth updating these too? Perhaps adding a asterisk / or a brief mention there that it's no longer officially supported?
lighthouse/book/src/installation.md
Line 3 in 3f6c11d
| Lighthouse runs on Linux, macOS, and Windows. |
| Lighthouse builds on Linux, macOS, and Windows. Install the [Dependencies](#dependencies) using |
These are the parts that I left it as it is as it still runs on Windows, but yeah I will add a note here too Edit: added a note in |
jimmygchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Remove most of the mention of
WindowsOS where unnecessary, and added a note about Windows build from source