Skip to content

Conversation

@NikhilSharmaWe
Copy link
Contributor

@NikhilSharmaWe NikhilSharmaWe commented Dec 4, 2025

Fixes: #57

@NikhilSharmaWe
Copy link
Contributor Author

NikhilSharmaWe commented Dec 6, 2025

@michaelsproul Could you please take a look at the changes and share your review?

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Could you also please look at adding some tests in https://github.com/sigp/milhouse/blob/main/src/tests/proptest/operations.rs

I noticed we don't have tests for regular iter_cow either, but we could get away with just testing iter_cow_from.

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.15%. Comparing base (dbe9e15) to head (c532da6).

Files with missing lines Patch % Lines
src/vector.rs 37.50% 5 Missing ⚠️
src/list.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   70.38%   70.15%   -0.24%     
==========================================
  Files          22       22              
  Lines        1263     1280      +17     
==========================================
+ Hits          889      898       +9     
- Misses        374      382       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NikhilSharmaWe
Copy link
Contributor Author

@michaelsproul Quick ping on this PR
The requested updates have been made. Would appreciate a follow-up review when time allows.

@michaelsproul
Copy link
Member

I'm off until Monday

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for pushing this along

For future PRs, make sure you run cargo fmt!

@michaelsproul michaelsproul merged commit 4d88c72 into sigp:main Dec 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add iter_cow_from

3 participants