-
Notifications
You must be signed in to change notification settings - Fork 20
feat: add iter_cow_from for List and Vector #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nikhil Sharma <[email protected]>
|
@michaelsproul Could you please take a look at the changes and share your review? |
michaelsproul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Could you also please look at adding some tests in https://github.com/sigp/milhouse/blob/main/src/tests/proptest/operations.rs
I noticed we don't have tests for regular iter_cow either, but we could get away with just testing iter_cow_from.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
- Coverage 70.38% 70.15% -0.24%
==========================================
Files 22 22
Lines 1263 1280 +17
==========================================
+ Hits 889 898 +9
- Misses 374 382 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Nikhil Sharma <[email protected]>
|
@michaelsproul Quick ping on this PR |
|
I'm off until Monday |
michaelsproul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for pushing this along
For future PRs, make sure you run cargo fmt!
Fixes: #57