Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LT-21737: Make highlight button work #199

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Conversation

jasonleenaylor
Copy link
Contributor

@jasonleenaylor jasonleenaylor commented Nov 7, 2024

  • Generate xhtml with a nodeId attribute that uses the ConfigurableDictionaryNode hash and use that to set highlight
  • Modify the 'Configure Dictionary' right click menu to use the nodeId attribute to select the correct tree node

This change is Reviewable

* Generate xhtml with a nodeId attribute that uses the
  ConfigurableDictionaryNode hash and use that to set highlight
* Modify the 'Configure Dictionary' right click menu to use the
  nodeId attribute to select the correct tree node
Copy link
Contributor

@aror92 aror92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jasonleenaylor)


Src/xWorks/DictionaryConfigurationController.cs line 1589 at r1 (raw file):

					}
				}
				if (topNode == null)

Why is it no longer necessary to check if topNode is null & return in that case?

@jasonleenaylor jasonleenaylor merged commit 3e559e7 into release/9.1 Nov 14, 2024
4 of 5 checks passed
@jasonleenaylor jasonleenaylor deleted the LT-21737 branch November 14, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants