-
-
Notifications
You must be signed in to change notification settings - Fork 5
tool: Add watch-for-rts-spike #3383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3383 +/- ##
=======================================
Coverage 82.21% 82.22%
=======================================
Files 608 608
Lines 36199 36199
Branches 5935 5930 -5
=======================================
+ Hits 29761 29764 +3
+ Misses 5563 5562 -1
+ Partials 875 873 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been using this script on our servers and it seems to be working well. I wanted to add it to our code repo to keep track of it.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
scripts/watch-for-rts-spike.mts
line 45 at r1 (raw file):
} const aboveThreshold: boolean = memoryUsageMB >= this.options.thresholdMib;
Hmm, I would be inclined to change this from >=
to >
, except that this is what is running on the server right now :)
This does not require testing because it is a developer tool. Although it can be used / tested by running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mark and I looked at this together. It seems we are not able to get it working on my windows machine. I looked through the code and it seems to be doing the right things.
@RaymondLuong3 reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @marksvc)
scripts/watch-for-rts-spike.mts
line 6 at r1 (raw file):
// sends SIGUSR2 signals at a configured interval so the target process can perform diagnostic actions. // Designed to help capture data around sudden RealtimeServer memory spikes.
Could you add a usage line with the necessary environment variables here.
Raymond and I had a look at how we might run this on Windows. |
When testing, make sure to run |
53a9c9a
to
fd66912
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RaymondLuong3)
scripts/watch-for-rts-spike.mts
line 6 at r1 (raw file):
Previously, RaymondLuong3 (Raymond Luong) wrote…
Could you add a usage line with the necessary environment variables here.
I added a note about SF_SIGUSR2_ACTION, as well as a pointer to diagnostics.ts
, which can be followed to learn about what happens when a report is requested.
fd66912
to
88b8335
Compare
This change is