Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW Allow changing parallelUploads config in UploadField #1539

Merged

Conversation

mikaldl
Copy link
Contributor

@mikaldl mikaldl commented Feb 4, 2025

Description

Adds option to change amount of parallel uploads

Manual testing steps

  • Add setMaxParallelUploads in the chain for UploadFields
  • Be sure to allow multiple file uploads

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

As this is my first time contributing for SilverStripe, please let me know what I could do better for future PRs. :) Thanks!

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 2 the default number of parallelUploads in dropzone itself?

You'll need to build new dist js files:

  • use nvm to install node 18
  • globally install the yarn with npm
  • in vendor/silverstripe/admin run yarn install
  • in vendor/silverstripe/asset-admin run yarn build
  • add the dist js files in a squashed commit (so there's a total of one commit for this PR)

@mikaldl mikaldl force-pushed the pulls/2/allow-parallel-uploads-config branch 2 times, most recently from 84d823b to 87be028 Compare February 11, 2025 13:19
@mikaldl
Copy link
Contributor Author

mikaldl commented Feb 11, 2025

As mentioned in the issue with the link towards the default settings of Dropzone, the default of dropzone is indeed 2.

Also thanks for the heads-up about the building with the tutorial, that was helpful! Added the new build file.

@mikaldl mikaldl requested a review from emteknetnz February 11, 2025 13:23
NEW Allow changing parallelUploads config in UploadField

NEW Allow changing parallelUploads config in UploadField

NEW Allow changing parallelUploads config in UploadField
@mikaldl mikaldl force-pushed the pulls/2/allow-parallel-uploads-config branch from 87be028 to 4182164 Compare February 11, 2025 13:37
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works well. Thanks for the PR 👍

@emteknetnz emteknetnz merged commit 0ef0b17 into silverstripe:2 Feb 11, 2025
15 of 16 checks passed
@emteknetnz emteknetnz mentioned this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants