-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW Allow changing parallelUploads config in UploadField #1539
NEW Allow changing parallelUploads config in UploadField #1539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 2
the default number of parallelUploads
in dropzone itself?
You'll need to build new dist js files:
- use nvm to install node 18
- globally install the yarn with npm
- in vendor/silverstripe/admin run
yarn install
- in vendor/silverstripe/asset-admin run
yarn build
- add the dist js files in a squashed commit (so there's a total of one commit for this PR)
84d823b
to
87be028
Compare
As mentioned in the issue with the link towards the default settings of Dropzone, the default of dropzone is indeed Also thanks for the heads-up about the building with the tutorial, that was helpful! Added the new build file. |
NEW Allow changing parallelUploads config in UploadField NEW Allow changing parallelUploads config in UploadField NEW Allow changing parallelUploads config in UploadField
87be028
to
4182164
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, works well. Thanks for the PR 👍
Description
Adds option to change amount of parallel uploads
Manual testing steps
setMaxParallelUploads
in the chain for UploadFieldsIssues
Pull request checklist
As this is my first time contributing for SilverStripe, please let me know what I could do better for future PRs. :) Thanks!