Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Don't throw console error if campaigns isn't installed #1551

Merged

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Mar 12, 2025

Fixes various failures in https://github.com/silverstripe/silverstripe-asset-admin/actions/runs/13803134628/job/38609073118 and https://github.com/silverstripe/silverstripe-cms/actions/runs/13803137179/job/38609088307 and https://github.com/silverstripe/silverstripe-elemental/actions/runs/13820952696

e.g.

[captured JavaScript error] Uncaught TypeError: Cannot read properties of undefined (reading 'schemaUrl') in http://localhost/_resources/vendor/silverstripe/admin/client/dist/js/vendor.js?m=1741750767:1:893686
STACKTRACE:
TypeError: Cannot read properties of undefined (reading 'schemaUrl')
    at M.renderEditor (<anonymous>:33:85316)
    at M.render (<anonymous>:33:86709)
    at As (http://localhost/_resources/vendor/silverstripe/admin/client/dist/js/vendor.js?m=1741750767:1:924348)
    at js (http://localhost/_resources/vendor/silverstripe/admin/client/dist/js/vendor.js?m=1741750767:1:924147)
    at Ou (http://localhost/_resources/vendor/silverstripe/admin/client/dist/js/vendor.js?m=1741750767:1:967185)
    at bl (http://localhost/_resources/vendor/silverstripe/admin/client/dist/js/vendor.js?m=1741750767:1:955484)
    at gl (http://localhost/_resources/vendor/silverstripe/admin/client/dist/js/vendor.js?m=1741750767:1:955412)
    at ml (http://localhost/_resources/vendor/silverstripe/admin/client/dist/js/vendor.js?m=1741750767:1:955275)
    at ol (http://localhost/_resources/vendor/silverstripe/admin/client/dist/js/vendor.js?m=1741750767:1:952110)
    at ul (http://localhost/_resources/vendor/silverstripe/admin/client/dist/js/vendor.js?m=1741750767:1:952492)
    And I click on the ".gallery__files .gallery-item__thumbnail" element # SilverStripe\BehatExtension\Context\BasicContext::iClickOnTheElement()
Saving screenshot into /home/runner/work/silverstripe-cms/silverstripe-cms/artifacts/screenshots/edit-a-page.feature_86.png
Saving HTML into /home/runner/work/silverstripe-cms/silverstripe-cms/artifacts/screenshots/zz_edit-a-page.feature_86.html
    And I press the "Insert file" button # SilverStripe\BehatExtension\Context\BasicContext::stepIPressTheButton()
      Insert file button not found
      Failed asserting that null is not null.

Issue

@emteknetnz emteknetnz merged commit b7e00bf into silverstripe:3.0 Mar 13, 2025
16 checks passed
@emteknetnz emteknetnz deleted the pulls/3.0/fix-campaign-bug branch March 13, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants