ENH CMS 6 compatibility #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/3.0/campaign-admin
branch
from
dcbe5be to
7391e6f
Compare
emteknetnz
changed the title
emteknetnz
force-pushed
the
pulls/3.0/campaign-admin
branch
3 times, most recently
from
b2062e7 to
a2826ba
Compare
emteknetnz
commented
Mar 5, 2025
| @@ -1,59 +0,0 @@ | |||
| /* global jest, jasmine, describe, it, expect, beforeEach */ | |||
|
|
|||
| import configureMockStore from 'redux-mock-store'; | |||
There was a problem hiding this comment.
This test was removed because 'redux-mock-store' wasn't compatible with latest version of redux. There was a link in the failed test to a page where the maintainers or redux recommend testing with react-testing-library instead. Since that kind of acts like a quasi behat test, and the fact we already have behat tests for campaign admin, I think we can safety just delete this test without a replacement
emteknetnz
commented
Mar 5, 2025
emteknetnz
force-pushed
the
pulls/3.0/campaign-admin
branch
from
a2826ba to
fca2c46
Compare
emteknetnz
commented
Mar 5, 2025
emteknetnz
commented
Mar 5, 2025
emteknetnz
commented
Mar 5, 2025
emteknetnz
force-pushed
the
pulls/3.0/campaign-admin
branch
from
fca2c46 to
5e7ba3e
Compare
emteknetnz
commented
Mar 5, 2025
emteknetnz
commented
Mar 5, 2025
emteknetnz
force-pushed
the
pulls/3.0/campaign-admin
branch
from
5e7ba3e to
da63674
Compare
emteknetnz
commented
Mar 5, 2025
emteknetnz
commented
Mar 5, 2025
emteknetnz
force-pushed
the
pulls/3.0/campaign-admin
branch
from
da63674 to
ecab072
Compare
emteknetnz
commented
Mar 5, 2025
emteknetnz
force-pushed
the
pulls/3.0/campaign-admin
branch
2 times, most recently
from
5aa1456 to
5ccd01c
Compare
emteknetnz
force-pushed
the
pulls/3.0/campaign-admin
branch
2 times, most recently
from
b2d8424 to
9d4cfab
Compare
GuySartorelli
requested changes
Mar 10, 2025
GuySartorelli
requested changes
Mar 10, 2025
emteknetnz
force-pushed
the
pulls/3.0/campaign-admin
branch
from
9d4cfab to
02cbef4
Compare
GuySartorelli
requested changes
Mar 10, 2025
|
Also please respond to #346 (review) |
emteknetnz
force-pushed
the
pulls/3.0/campaign-admin
branch
from
02cbef4 to
b61b41f
Compare
emteknetnz
force-pushed
the
pulls/3.0/campaign-admin
branch
from
b61b41f to
a6bdde7
Compare
Have updated styling |
emteknetnz
force-pushed
the
pulls/3.0/campaign-admin
branch
from
a6bdde7 to
9836a98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue https://github.com/silverstripeltd/product-issues/issues/895
Requirement is in framework so we don't need to include it here as well
It's also the CMS 5 version of the plugin so means that campaign-admin currently isn't installable with CMS 6