Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Make PageinatedList::count() give the number of items in the current page #11634

Merged
merged 1 commit into from
Mar 13, 2025
Merged

FIX Make PageinatedList::count() give the number of items in the current page #11634

merged 1 commit into from
Mar 13, 2025

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli mentioned this pull request Mar 11, 2025
Closed
2 tasks
@GuySartorelli
Copy link
Member Author

CI failures are also happening on the 6.0 branch directly: https://github.com/silverstripe/silverstripe-framework/actions/runs/13798065981

emteknetnz
emteknetnz requested changes Mar 12, 2025
View reviewed changes
@GuySartorelli GuySartorelli force-pushed the pulls/6.0/paginated-list-count branch from 29f9568 to e7d7dd7 Compare March 12, 2025 02:45
emteknetnz
emteknetnz reviewed Mar 12, 2025
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested locally, works well. Will approve + merge once CMS 5 PRs have been merged + merged up

@GuySartorelli GuySartorelli force-pushed the pulls/6.0/paginated-list-count branch 2 times, most recently from d130aea to 4ae68fb Compare March 12, 2025 03:44
@GuySartorelli GuySartorelli force-pushed the pulls/6.0/paginated-list-count branch from 4ae68fb to 8b2b38d Compare March 12, 2025 03:45
@emteknetnz
Copy link
Member

emteknetnz commented Mar 12, 2025 •
edited
Loading

Failing build, hasn't been merged-up/rebased?

@GuySartorelli
Copy link
Member Author

See #11634 (comment) above.

@emteknetnz emteknetnz merged commit 0267e60 into silverstripe:6.0 Mar 13, 2025
9 of 12 checks passed
@emteknetnz emteknetnz deleted the pulls/6.0/paginated-list-count branch March 13, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz