Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line event handlers to DataCurve #1752

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Add line event handlers to DataCurve #1752

merged 1 commit into from
Feb 3, 2025

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Feb 3, 2025

Fix #1720

[DataCurve] Add props onLineClick, onLineEnter and onLineLeave

The three new line event handlers all receive the index of the line segment that was interacted with, just like the three existing data point event handlers.

I didn't change the Interactive story since the actions add-on already logs the new events by default:

image

@axelboc axelboc requested a review from loichuder February 3, 2025 11:54
Copy link
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice integration in the existing code

@axelboc axelboc merged commit dcdcf3c into main Feb 3, 2025
8 checks passed
@axelboc axelboc deleted the line-evts branch February 3, 2025 15:01
@chanmSC
Copy link

chanmSC commented Feb 4, 2025

Spectacular! Thank you for this feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onLineEnter() Function Param to Highlight DataCurve
3 participants