Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp: Add ' as possible digit separator #1890

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

imp: Add ' as possible digit separator #1890

wants to merge 1 commit into from

Conversation

ThreeFx
Copy link

@ThreeFx ThreeFx commented Jul 18, 2022

It is used for Swiss Francs: CHF 1'000

@ghost
Copy link

ghost commented Jul 18, 2022

Review on Crocodile

@Xitian9
Copy link
Collaborator

Xitian9 commented Jul 18, 2022

This requires careful consideration to make sure we don't mess up parsing in other cases. See related discussion at #1489, #273.

@simonmichael
Copy link
Owner

@ThreeFx, thanks for this. Some ideas to move it forward:

  • update the docs in hledger.m4.md > Decimal marks, digit group marks
  • add a test or two, I think numbers.test would be the right place
  • at least manually sanity-check that it works as expected in the commodity directive and --commodity option

@simonmichael simonmichael added A-WISH Some kind of improvement request, hare-brained proposal, or plea. cli Command line parsing, options, arguments and suchlike. journal The journal file format, and its features. labels Jul 31, 2022
@ThreeFx ThreeFx force-pushed the master branch 3 times, most recently from b931f3f to 05f3c69 Compare January 19, 2023 19:52
@ThreeFx
imp: Add ' as possible digit separator
eb414aa 
It is used for Swiss Francs: CHF 1'000.
@simonmichael simonmichael added needs:testing To unblock: needs more developer testing or general usage needs:docs To unblock: needs corresponding documentation or doc updates needs:tests To unblock: needs more automated tests or test updates needs:rebase To unblock: needs to be rebased against latest master branch labels Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-WISH Some kind of improvement request, hare-brained proposal, or plea. cli Command line parsing, options, arguments and suchlike. journal The journal file format, and its features. needs:docs To unblock: needs corresponding documentation or doc updates needs:rebase To unblock: needs to be rebased against latest master branch needs:testing To unblock: needs more developer testing or general usage needs:tests To unblock: needs more automated tests or test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThreeFx @Xitian9 @simonmichael