Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in inversion notebook #15

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Fix typo in inversion notebook #15

merged 2 commits into from
Jan 24, 2024

Conversation

rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Jan 24, 2024

Replace distancee for distance.

Github is saying the outputs changed, which I don't think is true!

This is the intended change:
image

@santisoler
Copy link
Member

Thanks @rowanc1. I'm seeing the diff and apparently there were some changes in some outputs:

$ nbdiff main notebooks/02-inversion-dc-resistivity-2d.ipynb
nbdiff notebooks/02-inversion-dc-resistivity-2d.ipynb (main) notebooks/02-inversion-dc-resistivity-2d.ipynb
--- notebooks/02-inversion-dc-resistivity-2d.ipynb (main)  (no timestamp)
+++ notebooks/02-inversion-dc-resistivity-2d.ipynb  2024-01-24 10:24:38.979579
## inserted before /cells/14/outputs/0:
+  output:
+    output_type: display_data
+    data:
+      image/png: iVBORw0K...<snip base64, md5=3f49c2b36d6902cb...>
+      text/plain: <Figure size 1000x200 with 1 Axes>

## deleted /cells/14/outputs/0:
-  output:
-    output_type: display_data
-    data:
-      image/png: iVBORw0K...<snip base64, md5=02239952714a4edc...>
-      text/plain: <Figure size 1000x200 with 1 Axes>

## inserted before /cells/16/outputs/0:
+  output:
+    output_type: display_data
+    data:
+      image/png: iVBORw0K...<snip base64, md5=46158db9d96045c2...>
+      text/plain: <Figure size 800x275 with 2 Axes>
+  output:
+    output_type: display_data
+    data:
+      image/png: iVBORw0K...<snip base64, md5=0a0c33139884e6bf...>
+      text/plain: <Figure size 800x275 with 2 Axes>

## deleted /cells/16/outputs/0-1:
-  output:
-    output_type: display_data
-    data:
-      image/png: iVBORw0K...<snip base64, md5=b10ab42c762a1991...>
-      text/plain: <Figure size 800x275 with 2 Axes>
-  output:
-    output_type: display_data
-    data:
-      image/png: iVBORw0K...<snip base64, md5=8768cedfac902767...>
-      text/plain: <Figure size 800x275 with 2 Axes>

## inserted before /cells/20/outputs/1:
+  output:
+    output_type: display_data
+    data:
+      image/png: iVBORw0K...<snip base64, md5=873af9cc8b297fdb...>
+      text/plain: <Figure size 700x500 with 1 Axes>

## deleted /cells/20/outputs/1:
-  output:
-    output_type: display_data
-    data:
-      image/png: iVBORw0K...<snip base64, md5=1e92e1784715d300...>
-      text/plain: <Figure size 700x500 with 1 Axes>

## modified /cells/21/source:
@@ -7,7 +7,7 @@ Here, we define the mesh used for the inversion. Not only will this define the n
 1. Because there are no currents in the air, we do not need to pad upwards. I.e. the top of the mesh corresponds to the top of the topography.
 2. We require at least 2-3 cells between each current electrode; with more accurate results being obtained when the minimum cell size is smaller. For a 2.5D problem geometry, we can discretize much finer.
 3. To be safe, the padding thickness should be at least 2-3 times the largest electrode spacing.
-4. The increase in cell size at increasing distancee from the current electrodes should not happen too abruptly. At each cell size, you should have a layer at least 4 cells thick before increasing the cell size.
+4. The increase in cell size at increasing distance from the current electrodes should not happen too abruptly. At each cell size, you should have a layer at least 4 cells thick before increasing the cell size.
 5. Finer discretization is required when topography is significant.



## inserted before /cells/61/outputs/0:
+  output:
+    output_type: display_data
+    data:
+      image/png: iVBORw0K...<snip base64, md5=eca66cbb5369f2b2...>
+      text/plain: <Figure size 1500x600 with 4 Axes>

## deleted /cells/61/outputs/0:
-  output:
-    output_type: display_data
-    data:
-      image/png: iVBORw0K...<snip base64, md5=b609a4e4c5bb17bc...>
-      text/plain: <Figure size 1500x600 with 4 Axes>

## inserted before /cells/65/outputs/0:
+  output:
+    output_type: display_data
+    data:
+      image/png: iVBORw0K...<snip base64, md5=b6e584ed8dbbbc6c...>
+      text/plain: <Figure size 700x900 with 6 Axes>

## deleted /cells/65/outputs/0:
-  output:
-    output_type: display_data
-    data:
-      image/png: iVBORw0K...<snip base64, md5=f4b5245f363e9f37...>
-      text/plain: <Figure size 700x900 with 6 Axes>

## inserted before /cells/67/outputs/0:
+  output:
+    output_type: display_data
+    data:
+      image/png: iVBORw0K...<snip base64, md5=3b5f547817488375...>
+      text/plain: <Figure size 800x275 with 2 Axes>
+  output:
+    output_type: display_data
+    data:
+      image/png: iVBORw0K...<snip base64, md5=bcc858437d4b8c52...>
+      text/plain: <Figure size 800x275 with 2 Axes>

## deleted /cells/67/outputs/0-1:
-  output:
-    output_type: display_data
-    data:
-      image/png: iVBORw0K...<snip base64, md5=1f84ce1701bdd8f6...>
-      text/plain: <Figure size 800x275 with 2 Axes>
-  output:
-    output_type: display_data
-    data:
-      image/png: iVBORw0K...<snip base64, md5=423b6287dcebf5a5...>
-      text/plain: <Figure size 800x275 with 2 Axes>

## inserted before /cells/71/outputs/0:
+  output:
+    output_type: display_data
+    data:
+      image/png: iVBORw0K...<snip base64, md5=03601356146385b0...>
+      text/plain: <Figure size 900x600 with 4 Axes>

## deleted /cells/71/outputs/0:
-  output:
-    output_type: display_data
-    data:
-      image/png: iVBORw0K...<snip base64, md5=7cf5133408f82d49...>
-      text/plain: <Figure size 900x600 with 4 Axes>

@santisoler
Copy link
Member

I've pushed changes to revert those modifications to the outputs

@santisoler
Copy link
Member

Now I'm merging this 🚀

Thanks for opening this PR!

@santisoler santisoler changed the title Typo Fix typo in inversion notebook Jan 24, 2024
@santisoler santisoler merged commit 225d169 into main Jan 24, 2024
2 checks passed
@santisoler santisoler deleted the feat/typo branch January 24, 2024 18:36
@rowanc1
Copy link
Member Author

rowanc1 commented Jan 24, 2024

Must have been saving in vscode that changed things, anyhow, glad its sorted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants