-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in inversion notebook #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @rowanc1. I'm seeing the diff and apparently there were some changes in some outputs: $ nbdiff main notebooks/02-inversion-dc-resistivity-2d.ipynb
nbdiff notebooks/02-inversion-dc-resistivity-2d.ipynb (main) notebooks/02-inversion-dc-resistivity-2d.ipynb
--- notebooks/02-inversion-dc-resistivity-2d.ipynb (main) (no timestamp)
+++ notebooks/02-inversion-dc-resistivity-2d.ipynb 2024-01-24 10:24:38.979579
## inserted before /cells/14/outputs/0:
+ output:
+ output_type: display_data
+ data:
+ image/png: iVBORw0K...<snip base64, md5=3f49c2b36d6902cb...>
+ text/plain: <Figure size 1000x200 with 1 Axes>
## deleted /cells/14/outputs/0:
- output:
- output_type: display_data
- data:
- image/png: iVBORw0K...<snip base64, md5=02239952714a4edc...>
- text/plain: <Figure size 1000x200 with 1 Axes>
## inserted before /cells/16/outputs/0:
+ output:
+ output_type: display_data
+ data:
+ image/png: iVBORw0K...<snip base64, md5=46158db9d96045c2...>
+ text/plain: <Figure size 800x275 with 2 Axes>
+ output:
+ output_type: display_data
+ data:
+ image/png: iVBORw0K...<snip base64, md5=0a0c33139884e6bf...>
+ text/plain: <Figure size 800x275 with 2 Axes>
## deleted /cells/16/outputs/0-1:
- output:
- output_type: display_data
- data:
- image/png: iVBORw0K...<snip base64, md5=b10ab42c762a1991...>
- text/plain: <Figure size 800x275 with 2 Axes>
- output:
- output_type: display_data
- data:
- image/png: iVBORw0K...<snip base64, md5=8768cedfac902767...>
- text/plain: <Figure size 800x275 with 2 Axes>
## inserted before /cells/20/outputs/1:
+ output:
+ output_type: display_data
+ data:
+ image/png: iVBORw0K...<snip base64, md5=873af9cc8b297fdb...>
+ text/plain: <Figure size 700x500 with 1 Axes>
## deleted /cells/20/outputs/1:
- output:
- output_type: display_data
- data:
- image/png: iVBORw0K...<snip base64, md5=1e92e1784715d300...>
- text/plain: <Figure size 700x500 with 1 Axes>
## modified /cells/21/source:
@@ -7,7 +7,7 @@ Here, we define the mesh used for the inversion. Not only will this define the n
1. Because there are no currents in the air, we do not need to pad upwards. I.e. the top of the mesh corresponds to the top of the topography.
2. We require at least 2-3 cells between each current electrode; with more accurate results being obtained when the minimum cell size is smaller. For a 2.5D problem geometry, we can discretize much finer.
3. To be safe, the padding thickness should be at least 2-3 times the largest electrode spacing.
-4. The increase in cell size at increasing distancee from the current electrodes should not happen too abruptly. At each cell size, you should have a layer at least 4 cells thick before increasing the cell size.
+4. The increase in cell size at increasing distance from the current electrodes should not happen too abruptly. At each cell size, you should have a layer at least 4 cells thick before increasing the cell size.
5. Finer discretization is required when topography is significant.
## inserted before /cells/61/outputs/0:
+ output:
+ output_type: display_data
+ data:
+ image/png: iVBORw0K...<snip base64, md5=eca66cbb5369f2b2...>
+ text/plain: <Figure size 1500x600 with 4 Axes>
## deleted /cells/61/outputs/0:
- output:
- output_type: display_data
- data:
- image/png: iVBORw0K...<snip base64, md5=b609a4e4c5bb17bc...>
- text/plain: <Figure size 1500x600 with 4 Axes>
## inserted before /cells/65/outputs/0:
+ output:
+ output_type: display_data
+ data:
+ image/png: iVBORw0K...<snip base64, md5=b6e584ed8dbbbc6c...>
+ text/plain: <Figure size 700x900 with 6 Axes>
## deleted /cells/65/outputs/0:
- output:
- output_type: display_data
- data:
- image/png: iVBORw0K...<snip base64, md5=f4b5245f363e9f37...>
- text/plain: <Figure size 700x900 with 6 Axes>
## inserted before /cells/67/outputs/0:
+ output:
+ output_type: display_data
+ data:
+ image/png: iVBORw0K...<snip base64, md5=3b5f547817488375...>
+ text/plain: <Figure size 800x275 with 2 Axes>
+ output:
+ output_type: display_data
+ data:
+ image/png: iVBORw0K...<snip base64, md5=bcc858437d4b8c52...>
+ text/plain: <Figure size 800x275 with 2 Axes>
## deleted /cells/67/outputs/0-1:
- output:
- output_type: display_data
- data:
- image/png: iVBORw0K...<snip base64, md5=1f84ce1701bdd8f6...>
- text/plain: <Figure size 800x275 with 2 Axes>
- output:
- output_type: display_data
- data:
- image/png: iVBORw0K...<snip base64, md5=423b6287dcebf5a5...>
- text/plain: <Figure size 800x275 with 2 Axes>
## inserted before /cells/71/outputs/0:
+ output:
+ output_type: display_data
+ data:
+ image/png: iVBORw0K...<snip base64, md5=03601356146385b0...>
+ text/plain: <Figure size 900x600 with 4 Axes>
## deleted /cells/71/outputs/0:
- output:
- output_type: display_data
- data:
- image/png: iVBORw0K...<snip base64, md5=7cf5133408f82d49...>
- text/plain: <Figure size 900x600 with 4 Axes> |
I've pushed changes to revert those modifications to the outputs |
Now I'm merging this 🚀 Thanks for opening this PR! |
Must have been saving in vscode that changed things, anyhow, glad its sorted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
distancee
fordistance
.Github is saying the outputs changed, which I don't think is true!
This is the intended change:
![image](https://private-user-images.githubusercontent.com/913249/299413597-b5abfca2-3d42-4b4e-8c1e-252ad7e920d3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5OTY0OTcsIm5iZiI6MTczODk5NjE5NywicGF0aCI6Ii85MTMyNDkvMjk5NDEzNTk3LWI1YWJmY2EyLTNkNDItNGI0ZS04YzFlLTI1MmFkN2U5MjBkMy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQwNjI5NTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kOGMwN2RjZjZkYjJkMTg0ODg2OWVlY2Y1NzM1ODE2NmU1NWZjN2M2MjFmZGRmZTMyZTUwNTcwNWZhYTIxNTczJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.d-TdSwg7JrCjNa7R0Yt6PigESEQDG_Fvm8jE72xx01M)