Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dist/latest/auto-events.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions src/auto-events.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,11 @@
if (!element) return log("no element found");
var sent = false;

var href = element.getAttribute("href");

var callback = function () {
if (!sent && !element.hasAttribute("target"))
document.location = element.getAttribute("href");
if (!sent && !element.hasAttribute("target") && href)
document.location = href;
sent = true;
};

Expand Down Expand Up @@ -117,7 +119,7 @@
break;
}
case "email": {
var href = element.getAttribute("href");

Check failure on line 122 in src/auto-events.js

View workflow job for this annotation

GitHub Actions / linting

'href' is already defined
event = (href.split(":")[1] || "").split("?")[0];
metadata.email = event;
break;
Expand Down
27 changes: 27 additions & 0 deletions test/unit/auto-events.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,31 @@ describe("auto-events", function () {
done();
}, 0);
});

it("uses stored href when link changes before callback", function (done) {
const events = [];
const dom = createDOM({
beforeRun(vm) {
vm.sa_event = function (name, metadata, cb) {
events.push({ name, metadata });
setTimeout(cb, 0);
};
vm.sa_event_loaded = true;
},
});

const link = dom.window.document.createElement("a");
link.href = "https://example.com/href";
link.target = "_blank";
dom.window.document.body.appendChild(link);

dom.window.saAutomatedLink(link, "outbound");

link.removeAttribute("href");

setTimeout(() => {
expect(events[0]).to.deep.include({ name: "outbound_example_com" });
done();
}, 5);
});
});
Loading