Do not validate identity flag to allow for sha1 values#98
Merged
sindresorhus merged 3 commits intosindresorhus:mainfrom Aug 30, 2025
Merged
Do not validate identity flag to allow for sha1 values#98sindresorhus merged 3 commits intosindresorhus:mainfrom
sindresorhus merged 3 commits intosindresorhus:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When several code signing identities have the same name,
codesignwill fail:codesignwill however work if you give it the matching sha1 for the identity to use.This change allow to use sha1 as well as identity name by removing the validation for the identity flag that allows for only the name. Not validating seemed fine (instead of validating either possibilities) since codesign will fail when the identity is not valid: