Skip to content

support output path arg #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gsabran wants to merge 1 commit into from
Closed

support output path arg #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,12 @@ const cli = meow(`
--overwrite Overwrite existing DMG with the same name
--identity=<value> Manually set code signing identity (automatic by default)
--dmg-title=<value> Manually set DMG title (must be <=27 characters) [default: App name]
-o, --output=<value> Output path for the DMG file

Examples
$ create-dmg 'Lungo.app'
$ create-dmg 'Lungo.app' Build/Releases
$ create-dmg 'Lungo.app' --output='MyApp.dmg'
`, {
importMeta: import.meta,
flags: {
Expand All @@ -42,6 +44,10 @@ const cli = meow(`
dmgTitle: {
type: 'string',
},
output: {
type: 'string',
shortFlag: 'o',
},
},
});

Expand Down Expand Up @@ -88,8 +94,8 @@ async function init() {
}

const dmgTitle = cli.flags.dmgTitle ?? appName;
const dmgFilename = `${appName} ${appInfo.CFBundleShortVersionString}.dmg`;
const dmgPath = path.join(destinationPath, dmgFilename);
const dmgPath = cli.flags.output ?? path.join(destinationPath, `${appName} ${appInfo.CFBundleShortVersionString}.dmg`);
const dmgFilename = path.basename(dmgPath);

if (dmgTitle.length > 27) {
ora.fail('The disk image title cannot exceed 27 characters. This is a limitation in a dependency: https://github.com/LinusU/node-alias/issues/7');
Expand Down
Loading