Skip to content

Reduce bookmark rewind window #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amyfain wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reduce bookmark rewind window #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tap_exacttarget/state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def get_last_record_value_for_table(state, table):
return None

date_obj = datetime.datetime.strptime(raw, DATE_FORMAT)
date_obj = date_obj - datetime.timedelta(days=1)
date_obj = date_obj - datetime.timedelta(hours=6)
Copy link

@luandy64 luandy64 Nov 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am reluctant to make this "default" change. If we need to do this, I think the best course of action is to make this a sort of config change where users can pass in their desired time and the tap adjusts accordingly.


return date_obj.strftime(DATE_FORMAT)

Expand Down