Fixed the integration tests by skipping "data_extension.my_test" stream#85
Open
RushiT0122 wants to merge 1 commit intomasterfrom
Open
Fixed the integration tests by skipping "data_extension.my_test" stream#85RushiT0122 wants to merge 1 commit intomasterfrom
RushiT0122 wants to merge 1 commit intomasterfrom
Conversation
kspeer825
suggested changes
May 9, 2022
| } | ||
|
|
||
| def streams_to_select(self): | ||
| def streams_to_select(self, is_discovery=False): |
Contributor
There was a problem hiding this comment.
Defining this logic in base in an anti-pattern. We should not abstract away the streams under test. It should be defined at the test level.
| if is_discovery: | ||
| return set(self.expected_metadata().keys()) | ||
|
|
||
| return set(self.expected_metadata().keys()) - {'event', 'list_subscriber', 'subscriber', 'data_extension.my_test'} |
Contributor
There was a problem hiding this comment.
Did you investigate why this stream is now failing? Is this a problem with test data, or a problem with the tap? When we lose coverage on a stream we need to root cause the issue. If the root cause cannot be easily determined then a backlog ticket should be created to investigate the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps