Skip to content

Support subquestions#35

Open
ChrisCoffey wants to merge 1 commit intosinger-io:masterfrom
ChrisCoffey:support-subquestions
Open

Support subquestions#35
ChrisCoffey wants to merge 1 commit intosinger-io:masterfrom
ChrisCoffey:support-subquestions

Conversation

@ChrisCoffey
Copy link

@ChrisCoffey ChrisCoffey commented Jul 9, 2021

Description of change

We've encountered the issue described in #13. The problem is that Typeform groups aren't actually questions. They're actually wrappers around lists of questions, so need to be parsed differently from other fields.

Here's an example of the group response from Typeform's field definition:

,
        {
            "id": "t74tqzY6gpow",
            "properties": {
                "button_text": "Continue",
                "fields": [
                    {
                        "id": "ne0ti8xNbxQo",
                        "properties": { 
                        ...
                        },
                        "ref": "21b08fa6-9e91-4e55-9b99-c646b058d246",
                        "title": "What was the first college you applied to?",
                        "type": "dropdown",
                        "validations": {
                            "required": true
                        }
                    },
                    ...
                ],
                "show_button": true
            },
            "ref": "59905e57-02a5-4e4e-b392-6292a52f1309",
            "title": "In this next section, we need some more information about the colleges that you applied to.",
            "type": "group"
        },

Note that each sub-field within the group has id, ref, and title, so they'll parse fine.

What is the best way to test this change?

@cmerrick
Copy link
Contributor

cmerrick commented Jul 9, 2021

Hi @ChrisCoffey, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

You did it @ChrisCoffey!

Thank you for signing the Singer Contribution License Agreement.

@ChrisCoffey ChrisCoffey force-pushed the support-subquestions branch from 544de48 to 248d46b Compare July 19, 2021 15:20
@ChrisCoffey
Copy link
Author

@pbegle Do you have any advice for testing this change?

@kjarrith
Copy link

Any status on this?

@maruskya
Copy link

maruskya commented Sep 9, 2022

@cmerrick is there any status update on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants