Open
Conversation
Contributor
|
Hi @ChrisCoffey, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
407e229 to
544de48
Compare
Contributor
|
You did it @ChrisCoffey! Thank you for signing the Singer Contribution License Agreement. |
…load these a questions Typo Typo
544de48 to
248d46b
Compare
Author
|
@pbegle Do you have any advice for testing this change? |
|
Any status on this? |
|
@cmerrick is there any status update on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
We've encountered the issue described in #13. The problem is that Typeform groups aren't actually questions. They're actually wrappers around lists of questions, so need to be parsed differently from other fields.
Here's an example of the
groupresponse from Typeform's field definition:, { "id": "t74tqzY6gpow", "properties": { "button_text": "Continue", "fields": [ { "id": "ne0ti8xNbxQo", "properties": { ... }, "ref": "21b08fa6-9e91-4e55-9b99-c646b058d246", "title": "What was the first college you applied to?", "type": "dropdown", "validations": { "required": true } }, ... ], "show_button": true }, "ref": "59905e57-02a5-4e4e-b392-6292a52f1309", "title": "In this next section, we need some more information about the colleges that you applied to.", "type": "group" },Note that each sub-field within the group has
id,ref, andtitle, so they'll parse fine.What is the best way to test this change?