account for overrides when generating new token #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #421 +/- ##
==========================================
+ Coverage 96.35% 96.37% +0.02%
==========================================
Files 37 37
Lines 1070 1077 +7
==========================================
+ Hits 1031 1038 +7
Misses 39 39
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Looks like this is working now, however I was not able to get the tests to pass locally without hard coding in adding the test state into oauth2.py. Seems like theres some kind of issue in Flask where its not preserving the session that gets created during the test. |
…y added for this update, but if they are then we need to account for the additional query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has overridden the OAuth model, the automatic token refresh will fail if the user has defined columns that are not nullable. The common use case for this seems to be the instance where the author has associations with multiple providers. The commit will fail because the provider_user_id and the provider_username are not carried over to the new token.
The proposed solution will end up added an additional query to get the existing entry and copying over any fields that are not nullable into the new token.