Implement easy import of schools from the ME #248
+724
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
some more verbose commit messages might be useful (instead of "temp commit") |
As you can see, this PR is set as a draft, so commit names will be changed soon (probably tomorrow). |
Igifigi
force-pushed
the
feature-easy_import_of_schools
branch
from
2db4b84
to
fe33c00
Compare
|
@twalen now it's ready for review :)) |
|
|
Igifigi
force-pushed
the
feature-easy_import_of_schools
branch
from
fe33c00
to
168e6b8
Compare
Igifigi
force-pushed
the
feature-easy_import_of_schools
branch
3 times, most recently
from
eecc457
to
121a358
Compare
Igifigi
force-pushed
the
feature-easy_import_of_schools
branch
from
121a358
to
57dcebd
Compare
MasloMaslane
reviewed
Oct 5, 2023
Comment on lines
+450
to
+451
| update_school(curr_rspo_school, db_school) | ||
| rows_affected += 1 |
There was a problem hiding this comment.
Changes from MoE may introduce new duplicates.
Suggested change
| update_school(curr_rspo_school, db_school) | |
| rows_affected += 1 | |
| try: | |
| with transaction.atomic(): | |
| update_school(curr_rspo_school, db_school) | |
| rows_affected += 1 | |
| except utils.IntegrityError: | |
| self.log( | |
| f'Warning: Django found a duplicate school. Please manually check the school {db_school.rspo} data in SIO database, ' | |
| 'current RSPO and the last backup. Something suspicious may be going on.' | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an algorithm that will bring order to school selection in SIO. Implemented script is used to import schools from the RSPO database, which is provided by the Ministry of Education and contains all educational institutions in Poland. Due to the poor quality of this data, it is likely that SIO administrators will modify school data. The task of this script is to detect which corrections from newer and more recent versions of the RSPO database should be accepted and applied, and which should not.