Add explicit catches and re-throw errors for every promise

This way the promise failures will hopefully become rejections of the
async functions they are in rather than "Uncaught (in promise)" errors
that bubble up to the top.

src/main/lib/github-interface.ts

@@ -252,21 +252,31 @@ export async function fetchNotificationsForAccount(
 			account,
 			notification
 		);
-		const promise = Promise.all([commentPromise, subjectPromise]);
+		const promise = Promise.all([commentPromise, subjectPromise]).catch(
+			(err) => {
+				throw err;
+			}
+		);
 		promises.push(promise);
-		promise.then(([commentData, subjectData]) => {
-			notes.push(
-				buildNoteFromData({
-					account,
-					notification,
-					subjectData,
-					commentData,
-				})
-			);
-		});
+		promise
+			.then(([commentData, subjectData]) => {
+				notes.push(
+					buildNoteFromData({
+						account,
+						notification,
+						subjectData,
+						commentData,
+					})
+				);
+			})
+			.catch((err) => {
+				throw err;
+			});
 	}
 
-	await Promise.all(promises);
+	await Promise.all(promises).catch((err) => {
+		throw err;
+	});
 
 	return notes;
 }

src/renderer/lib/gitnews-fetcher.ts

@@ -155,12 +155,16 @@ export function createFetcher(): Middleware<{}, AppReduxState> {
 				);
 				const promise = fetchNotifications(account);
 				promises.push(promise);
-				promise.then((notes) => {
-					if ('error' in notes) {
-						throw notes.error;
-					}
-					allNotes = [...allNotes, ...notes];
-				});
+				promise
+					.then((notes) => {
+						if ('error' in notes) {
+							throw notes.error;
+						}
+						allNotes = [...allNotes, ...notes];
+					})
+					.catch((err) => {
+						throw new Error(err);
+					});
 			}
 
 			await Promise.all(promises);