Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store accounts in main store so they migrate properly #188

Merged
merged 9 commits into from
Sep 9, 2024
Merged

Store accounts in main store so they migrate properly #188

merged 9 commits into from
Sep 9, 2024

Conversation

sirbrillig
Copy link
Owner

@sirbrillig sirbrillig commented Sep 9, 2024 •
edited
Loading

This is a follow-up to #187 which fixes and cleans up some things to improve the experience with accounts.

  • Persist accounts across apps (allows for upgrades).
  • Properly parse errors when fetching fails to show reason.
  • Fix immediate fetch when accounts change.

@sirbrillig sirbrillig marked this pull request as ready for review September 9, 2024 17:30
@sirbrillig sirbrillig merged commit 52bcdda into trunk Sep 9, 2024
1 check passed
@sirbrillig sirbrillig deleted the more-account-fixes branch September 9, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sirbrillig