-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service-workers race token
to request and its lookup
#1
Conversation
fetch.bs
Outdated
<dt><var>request</var>'s <a for=request>service-workers race token</a> is not null | ||
<dd> | ||
<ol> | ||
<li><p>Let <var>raceReesponse</var> to the result of [=lookup-race-response=] given <var>request</var>'s <a for=request>service-workers race token</a>, <var>request</var>'s <a for=request>reserved client</a>, <var>request</var>'s <a for=request>URL</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will [=lookup-race-response=] be defined in SW spec?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I guess we only do the matching for HTTP/HTTPS and GET request. Do we do such restriction here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will [=lookup-race-response=] be defined in SW spec?
Yes. It's added in yoshisatoyanagisawa/ServiceWorker#10. I'm not sure if we have a good way to call an upcoming algorithm.
Also, I guess we only do the matching for HTTP/HTTPS and GET request. Do we do such restriction here?
Those are described in yoshisatoyanagisawa/ServiceWorker#10. The token is set under those restrictions. I guess we don't have to rephrase them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
This looks not a bikeshed code, I am not sure how external specifications can be linked here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then, I do not have any other comments.
Close this PR for now, and make another PR to the original fetch repository. |
Now the PR in whatwg#1737 |
This is a fetch spec update corresponding to the change in yoshisatoyanagisawa/ServiceWorker#10