Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service-workers race token to request and its lookup #1

Closed
wants to merge 2 commits into from

Conversation

sisidovski
Copy link
Owner

@sisidovski sisidovski commented Feb 14, 2024

This is a fetch spec update corresponding to the change in yoshisatoyanagisawa/ServiceWorker#10

fetch.bs Outdated
<dt><var>request</var>'s <a for=request>service-workers race token</a> is not null
<dd>
<ol>
<li><p>Let <var>raceReesponse</var> to the result of [=lookup-race-response=] given <var>request</var>'s <a for=request>service-workers race token</a>, <var>request</var>'s <a for=request>reserved client</a>, <var>request</var>'s <a for=request>URL</a>.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will [=lookup-race-response=] be defined in SW spec?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I guess we only do the matching for HTTP/HTTPS and GET request. Do we do such restriction here?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will [=lookup-race-response=] be defined in SW spec?

Yes. It's added in yoshisatoyanagisawa/ServiceWorker#10. I'm not sure if we have a good way to call an upcoming algorithm.

Also, I guess we only do the matching for HTTP/HTTPS and GET request. Do we do such restriction here?

Those are described in yoshisatoyanagisawa/ServiceWorker#10. The token is set under those restrictions. I guess we don't have to rephrase them.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@yoshisatoyanagisawa
Copy link

This looks not a bikeshed code, I am not sure how external specifications can be linked here.

Copy link

@yoshisatoyanagisawa yoshisatoyanagisawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then, I do not have any other comments.

@sisidovski
Copy link
Owner Author

Close this PR for now, and make another PR to the original fetch repository.

@sisidovski sisidovski closed this Feb 16, 2024
@sisidovski
Copy link
Owner Author

Now the PR in whatwg#1737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants