Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 代码块内 Ctrl+A 全选文本时不应选中末尾的换行符 #14008

Closed
wants to merge 2 commits into from

Conversation

TCOTC
Copy link
Contributor

@TCOTC TCOTC commented Feb 3, 2025

fix #13994

fix #14002 (后面已经替换零宽空格了,前面就不需要替换了)

@TCOTC TCOTC marked this pull request as draft February 3, 2025 07:20
@TCOTC TCOTC changed the title refactor: clean code fix: 代码块内 Ctrl+A 全选文本时不应选中末尾的换行符 Feb 3, 2025
@TCOTC TCOTC marked this pull request as ready for review February 3, 2025 09:21
@Vanessa219
Copy link
Member

复制的时候进行了处理,ctrl+A 保持全部选中吧。

@Vanessa219 Vanessa219 closed this Feb 3, 2025
@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 3, 2025

复制的时候处理会少一个换行 #13994 ,只能在选择的时候处理

Vanessa219 added a commit that referenced this pull request Feb 4, 2025
@Vanessa219
Copy link
Member

好的,那再改进一下。

@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 4, 2025

我觉得这里的两个 .replace(Constants.ZWSP, "") 也可以去掉,因为后面会替换

Vanessa219 added a commit that referenced this pull request Feb 5, 2025
@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 5, 2025

好像没有必要单独拆一个 codeBlockElement :

image

@TCOTC TCOTC deleted the fix/14002 branch February 5, 2025 08:41
Vanessa219 added a commit that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants