Skip to content

Improve UI layout #15011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Improve UI layout #15011

wants to merge 2 commits into from
+22 −1

Conversation

@TCOTC
Copy link
Contributor

@TCOTC TCOTC commented Jun 11, 2025 •
edited
Loading

fix #14856

@TCOTC TCOTC changed the title 🐛 No longer show the scrollbar at the bottom of the interface No longer show the scrollbar at the bottom of the interface Jun 11, 2025
@TCOTC TCOTC mentioned this pull request Jun 11, 2025
Closed
3 tasks
@TCOTC TCOTC changed the title No longer show the scrollbar at the bottom of the interface Improve sidebar Jun 11, 2025
@88250 88250 requested a review from Vanessa219 October 4, 2025 12:16
@88250 88250 added this to the 3.3.5 milestone Oct 4, 2025
@88250 88250 modified the milestones: 3.3.5, 3.3.6 Oct 14, 2025
@Vanessa219
Copy link
Member

Vanessa219 commented Oct 23, 2025

app/src/layout/util.ts 这个的改动会导致 #10048 问题。第一个视频中的情况无法重现，但看上去没有问题，我先手动合并了第一个修改点了。

Vanessa219 added a commit that referenced this pull request Oct 23, 2025
@Vanessa219
🎨 #15011
fc665fb
@Vanessa219
Copy link
Member

Vanessa219 commented Oct 23, 2025

我重新修改了下，你看一下2和3还能不能重现？

@Vanessa219 Vanessa219 closed this Oct 23, 2025
@Vanessa219
Copy link
Member

Vanessa219 commented Oct 23, 2025

改进窗口过小问题
QQ20251023-120143

Vanessa219 added a commit that referenced this pull request Oct 23, 2025
@Vanessa219
🎨 #15011
9366b0f
@Vanessa219 Vanessa219 self-assigned this Oct 23, 2025
@TCOTC
Copy link
Contributor Author

TCOTC commented Oct 23, 2025 •
edited
Loading

@Vanessa219

01

我刚刚发现 this.layout 好像始终会有两个 children，也许可以把 if (this.layout.children.length > 1) { 改成 if (this.layout.children.length > 0) { ？

02

可以在 this.layout.children[0].element.nextElementSibling?.classList.add("fn__none"); 后面添加注释：// separator，方便以后看到代码知道这个元素是什么

03

第二个提交之后，往外拖拽侧栏，侧栏宽度不会实时变化了，要松开鼠标才能看到效果：

video.webm

@TCOTC TCOTC deleted the fix/14856-01 branch October 23, 2025 08:27
Vanessa219 added a commit that referenced this pull request Oct 23, 2025
@Vanessa219
🎨 #15011
929a516
@88250 88250 changed the title Improve sidebar Improve UI layout Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vanessa219 Vanessa219 Awaiting requested review from Vanessa219

Assignees

@Vanessa219 Vanessa219

@TCOTC TCOTC

Labels

Enhancement

Projects

None yet

Milestone

3.3.6

Development

Successfully merging this pull request may close these issues.

3 participants

@TCOTC @Vanessa219 @88250