Set trigger button type to button for Tooltip, Popover and Modal (#…

…3208)
skeletonlabs · Feb 11, 2025 · 43cfd0b · 43cfd0b
1 parent 461d9de
commit 43cfd0b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/angry-hats-hear.md b/.changeset/angry-hats-hear.md
@@ -0,0 +1,5 @@
+---
+'@skeletonlabs/skeleton-svelte': patch
+---
+
+feat: set trigger button type to `button` for **Tooltip**, **Popover** and **Modal**
diff --git a/packages/skeleton-svelte/src/lib/components/Modal/Modal.svelte b/packages/skeleton-svelte/src/lib/components/Modal/Modal.svelte
@@ -70,7 +70,7 @@
 
 <span class="{base} {classes}" data-testid="modal">
 	<!-- Trigger -->
-	<button {...triggerProps} class="{triggerBase} {triggerBackground} {triggerClasses}" {disabled}>
+	<button {...triggerProps} class="{triggerBase} {triggerBackground} {triggerClasses}" {disabled} type="button">
 		{@render trigger?.()}
 	</button>
 

diff --git a/packages/skeleton-svelte/src/lib/components/Popover/Popover.svelte b/packages/skeleton-svelte/src/lib/components/Popover/Popover.svelte
@@ -63,7 +63,7 @@
 
 <span class="{base} {classes}" data-testid="popover">
 	<!-- Snippet: Trigger -->
-	<button {...triggerProps} class="{triggerBase} {triggerBackground} {triggerClasses}" {disabled}>
+	<button {...triggerProps} class="{triggerBase} {triggerBackground} {triggerClasses}" {disabled} type="button">
 		{@render trigger?.()}
 	</button>
 	<!-- Portal -->

diff --git a/packages/skeleton-svelte/src/lib/components/Tooltip/Tooltip.svelte b/packages/skeleton-svelte/src/lib/components/Tooltip/Tooltip.svelte
@@ -64,7 +64,7 @@
 
 <span class="{base} {classes}" data-testid="tooltip">
 	<!-- Snippet: Trigger -->
-	<button {...triggerProps} class="{triggerBase} {triggerBackground} {triggerClasses}" {disabled}>
+	<button {...triggerProps} class="{triggerBase} {triggerBackground} {triggerClasses}" {disabled} type="button">
 		{@render trigger?.()}
 	</button>
 	<!-- Tooltip Content -->