-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add slots to allow customizing AccordionItem open/close icons #2285
feat: Add slots to allow customizing AccordionItem open/close icons #2285
Conversation
🦋 Changeset detectedLatest commit: b178e0b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@bshore one minor issue noted above - FYI I'm currently limited to running PR audits on weekends, so expect a deeper review later this week. Thanks! |
@bshore I've made a few notable modifications:
I'm still not fond of having to update the icons per item, but well chalk that up to a Svelte v4 limitation and plan to revisit for our Svelte v5 rewrite coming soon! Overall, great job. We appreciate your contribution! |
Linked Issue
N/A - Discussed in Discord #contributors channel.
Description
Adds two optional slots for customizing the
AccordionItem
icon when open or closed.iconClosed
- What to display when the givenAccordionItem
is closed.iconOpen
- What to display when the givenAccordionItem
is open.Updated the component documentation page with a showcase + code example.
Preview Link
Changsets
Instructions: Changesets automate our changelog. If you modify files in
/packages
, runpnpm changeset
in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should beminor
while chores and bugfixes should bepatch
. Please prefix the changeset message withfeat:
,bugfix:
orchore:
.Checklist
Please read and apply all contribution requirements.
dev
branch (NEVERmaster
)docs/
,feat/
,chore/
,bugfix/
pnpm ci:check
pnpm format
pnpm test