Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified keyed update on ToC docs #2296

Merged

Conversation

phamduylong
Copy link
Contributor

Linked Issue

Closes #2294

Description

Added a bit more descriptive information on which typical case would be useful for keyed update, made changes to code block.

Couldn't find a better way to animate this and give a better example. Do feedback if you have better ideas in mind.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

changeset-bot bot commented Dec 7, 2023

⚠️ No Changeset found

Latest commit: f525587

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Dec 18, 2023 8:40pm

@endigo9740
Copy link
Contributor

endigo9740 commented Dec 18, 2023

@phamduylong We tend to favor ultra minimal examples, otherwise folks are prone to check out, skim, and miss valuable information. Here's what I've worked up:

Screenshot 2023-12-18 at 2 37 19 PM

@phamduylong
Copy link
Contributor Author

phamduylong commented Dec 18, 2023

@endigo9740 I think part of the original issue was that tabIndex wasn't supposed to be const (since it was intended to change). Otherwise looks good to me.

@endigo9740
Copy link
Contributor

endigo9740 commented Dec 18, 2023

@phamduylong I was pushing a fix for that when you responded! Screenshot updated above.

@endigo9740 endigo9740 merged commit 9e8fc22 into skeletonlabs:dev Dec 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update how keyed feature works in the Table of Contents docs
2 participants