-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified keyed update on ToC docs #2296
Modified keyed update on ToC docs #2296
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@phamduylong We tend to favor ultra minimal examples, otherwise folks are prone to check out, skim, and miss valuable information. Here's what I've worked up: |
@endigo9740 I think part of the original issue was that tabIndex wasn't supposed to be const (since it was intended to change). Otherwise looks good to me. |
@phamduylong I was pushing a fix for that when you responded! Screenshot updated above. |
Linked Issue
Closes #2294
Description
Added a bit more descriptive information on which typical case would be useful for keyed update, made changes to code block.
Couldn't find a better way to animate this and give a better example. Do feedback if you have better ideas in mind.
Changsets
Instructions: Changesets automate our changelog. If you modify files in
/packages
, runpnpm changeset
in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should beminor
while chores and bugfixes should bepatch
. Please prefix the changeset message withfeat:
,bugfix:
orchore:
.Checklist
Please read and apply all contribution requirements.
dev
branch (NEVERmaster
)docs/
,feat/
,chore/
,bugfix/
pnpm ci:check
pnpm format
pnpm test