Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/url tab state #2311

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Docs/url tab state #2311

merged 4 commits into from
Dec 18, 2023

Conversation

Hugos68
Copy link
Contributor

@Hugos68 Hugos68 commented Dec 13, 2023

Linked Issue

Closes #2303

Description

  • Added reactive block that syncs the currently selected doc tab in the url using a ?tab= query param.
  • Added a default tab constant, whenever the currently selected tab is the default tab instead of updating the tab query param the tab query param is removed.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

changeset-bot bot commented Dec 13, 2023

⚠️ No Changeset found

Latest commit: 6260d79

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Dec 18, 2023 7:37pm

@endigo9740
Copy link
Contributor

@Hugos68 I implement a minor refactor and added a compliment to make it clear what this is handling. Great job, this will prove super useful for support going forward!

@endigo9740 endigo9740 merged commit cd3c6c1 into skeletonlabs:dev Dec 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tab deep linking support to DocShell layout
3 participants