Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to modern standard for scrollbar styles #2596

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

endigo9740
Copy link
Contributor

@endigo9740 endigo9740 commented Apr 5, 2024

Linked Issue

Closes #2538

Description

Migrates the Skeleton plugin base styles from the -webkit- vendor prefix to the new modern standards described here:

This matches the exact implementation in Skeleton v3, which better prepares for the transition going forward.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

changeset-bot bot commented Apr 5, 2024

🦋 Changeset detected

Latest commit: 9304823

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/tw-plugin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skeleton-next ❌ Failed (Inspect) Apr 5, 2024 8:53pm
skeleton-themes ❌ Failed (Inspect) Apr 5, 2024 8:53pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
skeleton-docs ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 8:53pm

@endigo9740 endigo9740 merged commit a4acb5a into dev Apr 8, 2024
5 of 7 checks passed
@endigo9740 endigo9740 deleted the bugfix/scrollbar-display-issue branch April 8, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Skeleton v2] - Light scrollbar is displayed instead of dark one on Opera browser
1 participant