Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Replace usage of deprecated tools in get started page #3169

Closed
wants to merge 1 commit into from

Conversation

AdiHarif
Copy link

Linked Issue

Closes #3161

Checklist

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

changeset-bot bot commented Jan 25, 2025

⚠️ No Changeset found

Latest commit: 47de931

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Jan 25, 2025 10:03am

Copy link

vercel bot commented Jan 25, 2025

@AdiHarif is attempting to deploy a commit to the Skeleton Labs Team on Vercel.

A member of the Team first needs to authorize it.

@endigo9740
Copy link
Contributor

endigo9740 commented Jan 25, 2025

Hi @AdiHarif this is well intentioned, but we're already aware that this would only be a temporary fix as sv is about to move to Tailwind v4 being the default add-on install:

I've talked with Ben McCann (lead of SvelteKIt) and he's suggested the idea of pinning the CLI to a set version to avoid this. However, sv and the v2 CLI install are not 1:1. They Skeleton CLI scaffolded more of your project, such as themes. So we're going to likely update the create-skeleton-app to pin the version of Tailwind rather than trying to transition to sv.

You can see plans for this here:

And it looks like a member of our team has handled this in this pending PR. So we'll test and get this out asap:

I'll go ahead and close your PR as it overlaps with these changes. But I appreciate the contribution all the same!

@endigo9740 endigo9740 closed this Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of deprecated svelte-add in Tailwind manual installation parts of the get started doc
2 participants