Add Oscnn implementation #111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @TonyBagnall Sir, it would be very generous of you if you could please take a look at this code and approve it. Thanks! |
Contributor
|
hi, sorry for the delay. We will need to set up pytorch correctly, I think thats why its failing, I'll ask someone as I am not sure. Could you document the code? We are looking to improve the style of comments, and are looking to make it more like sktime. You can see here for the stryle we would like https://github.com/alan-turing-institute/sktime/blob/main/sktime/classification/dictionary_based/_boss.py |
27 tasks
Contributor
|
@tabhishek432, would you like to move this code to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes sktime/sktime#5828What does this implement/fix? Explain your changes.
It implements OSCNNDoes your contribution introduce a new dependency? If yes, which one?
Yes, it requires to install torch (pytorch)Any other comments?
OSCNN is implemented in pytorch rather than tensorflow