-
Notifications
You must be signed in to change notification settings - Fork 10
Add StarGuard support, rename SubDAOs to Prime Agents #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| * IF Prime Agent spell is provided | ||
| * [ ] Handover message matches `XXX spell YYYY-MM-DD deployed to 0x… with hash 0x…, direct execution: yes / no` template | ||
| * [ ] IF `direct execution` is `no` | ||
| * [ ] The spell is plotted using `StarGuardLike(XXX_STARGUARD).plot(XXX_SPELL, XXX_SPELL_HASH)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, update the name here as well.
|
I think it would be helpful to add the verification commands, near L253
Something like: What do you think? |
|
Checklist looks good! Just one note after seeing the first interactions with Star teams after Starguard: I think the Star teams should not chose "direct execution", we should just default to running their spells through Starguard, and fallback to direct execution only if truly needed (on an exception basis. If they need to run something direct they should go through the usual core spell process, including core process forum post, then polling, then Govops includes the items in the exec-sheet/doc). Basically pushing them towards using the tool (safer, decoupled from the main spell, etc.) by making the other "direct" path way more difficult. This is not a blocker though, it's something that can be discussed later on. |
@riccardopersiani I think this is out of scope of this PR that adds StarGuard support, so you can open a separate PR. Historically, through, core developers never verified source code of the Star Spells as this is done by the Star spell reviewers.
I agree, it is recommended to use StarGuard. But it's important that "direct execution" is always considered and explicitly specified by the Star team – it should not be a responsibility of the core to consider it. The responsibility of the core is to scrutinise if the reason for "direct execution" is good enough. |
This PR: