Rewrite deploy script #448
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amusingaxl
reviewed
Feb 20, 2025
Comment on lines
+5
to
+7
| CHAIN_ID = '1' | ||
| OPTIMIZER_ENABLED = 'false' | ||
| OPTIMIZER_RUNS = '200' |
Contributor
There was a problem hiding this comment.
Now that we'll use Foundry only, wouldn't it be better to move this to foundry.toml instead?
Suggested change
| CHAIN_ID = '1' | |
| OPTIMIZER_ENABLED = 'false' | |
| OPTIMIZER_RUNS = '200' | |
| CHAIN_ID = '1' | |
| OPTIMIZER_ENABLED = 'false' | |
| OPTIMIZER_RUNS = '200' |
Comment on lines
+53
to
+56
| '--optimize', OPTIMIZER_ENABLED, | ||
| '--optimizer-runs', OPTIMIZER_RUNS, | ||
| '--use', SOLIDITY_USE, | ||
| '--libraries', f'lib/dss-exec-lib/src/DssExecLib.sol:DssExecLib:{EXEC_LIB_ADDRESS}', |
Contributor
There was a problem hiding this comment.
Also --libraries could be moved to foundry.toml.
We could even get rid of the DssExecLib.address file.
Contributor
Author
|
Taken over / replaced by #491 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites deployment script to use foundry instead of dapp.tools.
The easiest way of testing this PR is to deploy a spell to anvil/tenderly fork, commenting out verification command. Deploying on a fork doesn't allow to check code verification, but it's actually not a problem, since verification code hasn't been modified in this PR.
Note: the verification script currently depends on the
out/dapp.sol.jsonfile produced by the dapp-tools. Before merging this PR, I would recommend to rewriteverify.pyscript into foundry (or otherwise loose dependency on thedapp.sol.json) in a separate PR.