Skip to content

Revamp verification script #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amusingaxl merged 13 commits into from
Jun 7, 2025
Merged

Revamp verification script #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
616e532
wip: revamp script
May 14, 2025
403df63
chore: refactor verify.py
May 20, 2025
29cfe9e
chore: remove sepolia refs
May 20, 2025
892b554
chore: address review comments
May 21, 2025
a6a10d1
chore: remove api-key ref in toml
May 21, 2025
1d2bd01
Merge branch 'master' into revamp-verify.py
May 21, 2025
d5c2c76
chore: update library with mainnet value
May 21, 2025
f31480b
Merge branch 'master' into revamp-verify.py
May 21, 2025
19a1133
chore: cancun evm
May 22, 2025
19730c5
fix: change `optimizer_runs` back to 200; fix typo
amusingaxl Jun 5, 2025
fe452e7
refactor: use AGPLv3 license by default
amusingaxl Jun 5, 2025
1680435
refactor: improve error handling and messages
amusingaxl Jun 5, 2025
e55b011
fix: update regex for extracting DssExecLib address from `foundry.toml`
amusingaxl Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion foundry.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,15 @@ fs_permissions = [
{ access = "read", path = "./lib/dss-test/script/input/"},
{ access = "read", path = "./out/ArbitrumDomain.sol/ArbSysOverride.json"}
]
solc_version = "0.8.16"
evm_version = "cancun"
optimizer = true
optimizer_runs = 200
via_ir = false
libraries = [
"./lib/dss-exec-lib/src/DssExecLib.sol:DssExecLib:0x8De6DDbCd5053d32292AAA0D2105A32d108484a6"
]
Comment on lines +14 to +16
Copy link
Contributor

@SidestreamColdMelon SidestreamColdMelon Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: It's technically out of scope of this PR to (partially) move DssExecLib address into foundry.toml. But fine for me to keep it, until the next PR is merged. No action required


[rpc_endpoints]
mainnet = "${ETH_RPC_URL}"

# See more config options https://github.com/gakonst/foundry/tree/master/config
4 changes: 2 additions & 2 deletions scripts/check-deployed-dssspell.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ fi
# Check verified spell linked library
library_address=$(echo "$verified_spell_info" | jq -r '.Library | split(":") | .[1]')
checksum_library_address=$(cast --to-checksum-address "$library_address")
if [ "$checksum_library_address" == "$(cat DssExecLib.address)" ]; then
success_check "DssSpell library matches hardcoded address in DssExecLib.address."
if [ "$checksum_library_address" == "$(cat foundry.toml | sed -nE 's/.*DssExecLib:(0x[0-9a-fA-F]{40}).*/\1/p')" ]; then
success_check "DssSpell library matches hardcoded address in foundry.toml."
else
error_check "DssSpell library does not match hardcoded address."
fi
Expand Down
Loading
Loading