Retry mechanism for verification in multiple explorers #487

0xLaz3r · 2025-09-01T14:01:29Z

Enhanced Contract Verification with Retry Mechanisms and Multi-Explorer Support

🎯 Summary

Enhances scripts/verify.py to eliminate single points of failure when verifying Sky Protocol spells. Adds robust retry mechanisms and support for multiple block explorers (Etherscan + Sourcify) with automatic fallback.

🔧 Key Changes

Retry Mechanisms

Exponential backoff with jitter for all API calls and subprocess operations
Configurable retry parameters: 3 attempts, 2s base delay, 60s max delay
Smart error handling with detailed logging

Multi-Explorer Support

Etherscan: Primary verifier (requires API key)
Sourcify: Backup verifier (no API key required)
Automatic fallback: If one fails, tries the next

Enhanced Error Handling

Graceful degradation when verifiers are unavailable
Comprehensive logging of all attempts and failures
Better error messages with clear failure reasons

📝 Files Changed

scripts/verify.py - Enhanced with retry mechanisms and multi-verifier support
scripts/verification/README.md - Updated documentation
scripts/verification/test_retry.py - Simple test for the retry mechanism

⚙️ Usage (Unchanged)

make verify addr=0x1234567890123456789012345678901234567890

✅ Benefits

Reliability: Multiple verifiers eliminate single points of failure
Resilience: Handles temporary network issues gracefully
Transparency: Detailed logging shows exactly what's happening
Compatibility: Existing workflows work unchanged

🧪 Testing

✅ Python syntax validation
✅ Retry mechanism verification
✅ Argument validation
✅ Environment variable validation

🎯 Addresses Requirements

✅ Verify on at least 2 block explorers
✅ Proper retry mechanisms with sane defaults
✅ Maintain existing Makefile command
✅ Eliminate single point of failure

No breaking changes - pure enhancement with full backward compatibility.

DaiFoundation-DevOps · 2025-09-01T14:01:34Z

All committers have signed the CLA.

coderabbitai · 2025-09-01T14:01:37Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

amusingaxl

Hey there, I left some comments and suggestions.

scripts/verify.py

scripts/verification/__init__.py

scripts/verification/README.md

scripts/verification/sourcify_verifier.py

scripts/verification/test_retry.py

scripts/verify.py

0xBasset · 2025-09-09T14:07:05Z

scripts/verification/etherscan_verifier.py

+"""
+Etherscan block explorer verifier implementation.
+"""
+import os


seems like this is unused

0xBasset · 2025-09-09T14:08:04Z

scripts/verification/sourcify_verifier.py

+"""
+import sys
+import json
+import time


This also seems unused

0xBasset · 2025-09-09T14:09:37Z

scripts/verification/test_retry.py

+import random
+import unittest
+from unittest.mock import patch, MagicMock
+from typing import Tuple, Callable
+
+from retry import retry_with_backoff, DEFAULT_MAX_RETRIES, DEFAULT_BASE_DELAY


random, MagicMock, Tuple, Callable, DEFAULT_MAX_RETRIES e DEFAULT_BASE_DELAY all seem unused

0xBasset · 2025-09-09T14:36:27Z

scripts/verification/etherscan_verifier.py

+            data['libraryaddress1'] = library_address
+
+        # Submit verification request with retry
+        max_retries = 3


Should this hardcoded value be here? Isn't it also set somewhere else?

scripts/verify.py

amusingaxl

LGTM

amusingaxl

Left some suggestions.

scripts/verification/sourcify_verifier.py

scripts/verification/etherscan_verifier.py

scripts/verification/contract_data.py

scripts/verification/verifier_sourcify.py

scripts/verification/retry_test.py

scripts/verify.py

0xBasset · 2025-10-27T20:31:24Z

scripts/verification/contract_data.py

+import json
+from typing import Dict, Any, Optional


Json, Dict and Any seems to be unused.

0xBasset · 2025-10-27T20:34:46Z

scripts/verification/README.md

+# ✅ Correct way - run as module
+python3 -m scripts.verification.test_retry


The test name needs updating here.

SidestreamBurningBanana · 2025-12-15T09:53:59Z

scripts/verification/verify.py

+    if library_address:
+        cmd.extend(["--libraries", f"src/DssExecLib.sol:DssExecLib:{library_address}"])


Since library is present in foundry.toml, can we get rid of all library parsing/passing inside the scripts?

SidestreamBurningBanana · 2025-12-15T10:10:47Z

scripts/verification/verify.py

+    # Etherscan (requires API key)
+    if chain_id == "1" and etherscan_api_key:


Awareness question - would hardcoding 1 allow for verification against Tenderly Testnets?
https://docs.tenderly.co/virtual-testnets/smart-contract-frameworks/foundry#verify-existing-contracts

From my understanding, testnets created from Mainnet will report chain ID of 1, so verify.py should work with them

Yeah, as long as we don't change the chain ID for Tenderly Virtual Testnets, it's fine.
I don't think we have a use case to change it regardless.

SidestreamBurningBanana · 2025-12-15T11:08:35Z

scripts/verification/contract_data.py

+            capture_output=True,
+            text=True,
+            check=True,
+            env=os.environ | {"ETH_GAS_PRICE": "0", "ETH_PRIO_FEE": "0"},


Question - why do ETH_GAS_PRICE and ETH_PRIO_FEE need to be set?

There was a bug in cast call that caused it to fail to execute if the sender didn't have enough gas to fund the call, even though it's supposed to be a read-only function.
Usually this command is executed in the same shell that executed the deployment, so those variables would most likely be set.
Not sure if they fixed it, but explicitly setting the gas price and the prio fee to zero was the workaround.

SidestreamBurningBanana · 2025-12-15T11:09:23Z

scripts/verification/contract_data.py

+        print("No foundry.toml found", file=sys.stderr)
+
+    # If we get here, no library address was found
+    print("WARNING: Assuming this contract uses no libraries", file=sys.stderr)


Question - does it ever make sense to continue with verification when no libraries are present?

SidestreamBurningBanana · 2025-12-15T11:12:00Z

scripts/verification/__init__.py

Question - what role does this index file play?

Please adjust Makefile to a correct file since currently Make cannot find ./scripts/verify.py

SidestreamBurningBanana · 2025-12-15T11:13:58Z

scripts/verification/contract_data.py

+    return chain_id
+
+
+def get_library_address() -> str:


As mentioned in the other place, I believe that libraries should be handled by forge itself, and not parsed/provided to it

SidestreamBurningBanana · 2025-12-15T11:16:56Z

scripts/verification/verify.py

+    if len(contract_address) != 42:
+        sys.exit('Malformed address')


nit: this can check against a regular expression which is safer for address detection since it also checks hex-format

I don't think this check is necessary.
If it's not a valid address, it will fail anyway.
This is more a guard against forgetting to set the address, or setting it so something different because of bad copy-pasta.

SidestreamBurningBanana · 2025-12-15T11:45:21Z

scripts/verification/verify.py

+    delay = int(os.environ.get("VERIFY_DELAY", "5"))
+
+    chain_id = get_chain_id()
+    etherscan_api_key = os.environ.get("ETHERSCAN_API_KEY", "")


Could you please check for the presence of a bug caused by the presence of a non-empty ETHERSCAN_API_KEY environment variable which causes Forge to always verify against etherscan even when other verifier has been specified.

This only happens when:

ETHERSCAN_API_KEY was set to a non-empty value;

--verifier sourcify.

This combination causes forge to never verify on Sourcify.

It is caused by this line which doesn't use sourcify when ETHERSCAN_API_KEY is there.

amusingaxl · 2026-01-13T14:15:46Z

scripts/verification/verify.py

+    if constructor_args:
+        cmd.extend(["--constructor-args", constructor_args])


Spells are not supposed to have constructor args. We can safely remove this.

amusingaxl

Left some notes.

amusingaxl · 2026-01-20T15:01:46Z

scripts/verification/README.md

+- Etherscan: used on mainnet when `ETHERSCAN_API_KEY` is set
+
+## Notes
+- Libraries: if `DssExecLib` is configured in `foundry.toml`, it is linked automatically via `--libraries`.


The CLI no longer accepts constructor args, as we're relying on foundry.toml. Please update the README do reflect that.

amusingaxl · 2026-01-20T15:02:50Z

scripts/verification/README.md

+export VERIFY_RETRIES=5
+export VERIFY_DELAY=5
+
+python -m scripts.verification.verify DssSpell 0xYourSpellAddress [constructorArgs]


Constructor args are not supported anymore.

Suggested change

python -m scripts.verification.verify DssSpell 0xYourSpellAddress [constructorArgs]

python -m scripts.verification.verify DssSpell 0x{spell_address}

amusingaxl · 2026-01-20T15:04:29Z

scripts/verification/contract_data.py

+and other contract-related data operations.
+"""
+import os
+import re


Unused

Suggested change

import re

amusingaxl · 2026-01-20T15:04:45Z

scripts/verification/contract_data.py

+# Constants
+SOURCE_FILE_PATH = "src/DssSpell.sol"
+LIBRARY_NAME = "DssExecLib"


Both unused in this file:

Suggested change

# Constants

SOURCE_FILE_PATH = "src/DssSpell.sol"

LIBRARY_NAME = "DssExecLib"

amusingaxl · 2026-01-20T15:12:29Z

scripts/verification/verify.py

+        return False
+
+
+def verify_contract_with_verifiers(


Probably it's best to inject both chain_id and etherscan_api_key as parameters than to fetch them locally

Suggested change

def verify_contract_with_verifiers(

def verify_contract_with_verifiers(

contract_name: str,

contract_address: str,

chain_id: str,

etherscan_api_key: str,

) -> bool:

amusingaxl · 2026-01-20T15:12:43Z

scripts/verification/verify.py

+        )
+
+        # Parse command line arguments
+        spell_name, spell_address = parse_command_line_args()


Suggested change

spell_name, spell_address = parse_command_line_args()

spell_name, spell_address = parse_command_line_args()

chain_id = get_chain_id()

etherscan_api_key = os.environ.get("ETHERSCAN_API_KEY", "")

amusingaxl · 2026-01-20T15:12:58Z

scripts/verification/verify.py

+        spell_name, spell_address = parse_command_line_args()
+
+        # Verify spell contract
+        spell_success = verify_contract_with_verifiers(


Suggested change

spell_success = verify_contract_with_verifiers(

spell_success = verify_contract_with_verifiers(

contract_name=spell_name,

contract_address=spell_address,

chain_id=chain_id,

etherscan_api_key=etherscan_api_key,

)

amusingaxl · 2026-01-20T15:13:10Z

scripts/verification/verify.py

+            print('Could not determine action contract address', file=sys.stderr)
+            sys.exit(1)
+
+        action_success = verify_contract_with_verifiers(


Suggested change

action_success = verify_contract_with_verifiers(

action_success = verify_contract_with_verifiers(

contract_name="DssSpellAction",

contract_address=action_address,

chain_id=chain_id,

etherscan_api_key=etherscan_api_key,

)

amusingaxl · 2026-01-20T15:19:27Z

scripts/verification/verify.py

+    retries = int(os.environ.get("VERIFY_RETRIES", "5"))
+    delay = int(os.environ.get("VERIFY_DELAY", "5"))


This function has one too many levels of abstraction going on.
Parsing environment variables and getting their default values shouldn't be part of its responsibilities.
You most likely want to inject those already parsed into the function as parameters and let the top level call deal with those.

amusingaxl · 2026-01-20T15:19:39Z

scripts/verify.py

Needs to resolve the conflict.

amusingaxl reviewed Sep 1, 2025

View reviewed changes

amusingaxl reviewed Sep 3, 2025

View reviewed changes

scripts/verify.py Outdated Show resolved Hide resolved

0xLaz3r marked this pull request as draft September 3, 2025 18:48

0xBasset requested changes Sep 9, 2025

View reviewed changes

0xLaz3r added 4 commits September 10, 2025 15:48

feat: ✨ implement retry mechanism for verification in multiple explorers

493e14e

refactor: 🔥 remove duplicated code

850b03f

refactor: ♻️ modify repo structure

7c3ec30

style: 🎨 remove unnecessary whitespaces

547d643

0xLaz3r force-pushed the retry-verify branch from d10c6d9 to 547d643 Compare September 10, 2025 13:57

test: ✅ skip testLockstakeStusdsInit test

fd22657

amusingaxl reviewed Sep 10, 2025

View reviewed changes

scripts/verify.py Outdated Show resolved Hide resolved

amusingaxl reviewed Sep 10, 2025

View reviewed changes

scripts/verify.py Outdated Show resolved Hide resolved

0xLaz3r added 2 commits September 24, 2025 12:22

fix: 🐛 move verifiers report outside for loop

4e1d4c4

Merge branch 'master' into retry-verify

408a1e6

0xLaz3r marked this pull request as ready for review September 24, 2025 10:30

amusingaxl previously approved these changes Sep 25, 2025

View reviewed changes

amusingaxl mentioned this pull request Sep 26, 2025

Rewrite deploy script to foundry #491

Merged

refactor: ♻️ remove flattening step from verification process

b4a1ac2

0xLaz3r dismissed amusingaxl’s stale review via b4a1ac2 October 15, 2025 13:25

0x3phemeralsoul requested review from 0xBasset and 0xdecr1pto October 20, 2025 13:52

amusingaxl reviewed Oct 24, 2025

View reviewed changes

0xLaz3r added 2 commits October 27, 2025 19:53

refactor: 🔥 remove references to sepolia

eea1b68

refactor: 🚚 rename verifiers files and classes

3fc520f

0xLaz3r requested a review from amusingaxl October 27, 2025 19:03

0xBasset requested changes Oct 27, 2025

View reviewed changes

0xLaz3r added 2 commits October 28, 2025 09:55

chore: 🔥 remove unused imports and fix README typo

6a49e3a

style: 🎨 run flake8 linter and black formatter

458e249

0xLaz3r requested a review from 0xBasset October 28, 2025 09:20

0xLaz3r added 4 commits November 17, 2025 11:09

refactor: ♻️ move verify.py into verification folder

64f0aab

refactor: 🔥 remove unnecessary verifier modules

d1eeef3

docs: 📝 update verification README.md

219a333

refactor: 🔥 remove unnecessary retry logic from contract data script

456e91c

SidestreamBurningBanana reviewed Dec 15, 2025

View reviewed changes

amusingaxl reviewed Jan 13, 2026

View reviewed changes

refactor: 🔥 remove unnecessary library address and constructor args

86e5688

amusingaxl reviewed Jan 20, 2026

View reviewed changes

		# ✅ Correct way - run as module
		python3 -m scripts.verification.test_retry

		if library_address:
		cmd.extend(["--libraries", f"src/DssExecLib.sol:DssExecLib:{library_address}"])

		# Etherscan (requires API key)
		if chain_id == "1" and etherscan_api_key:

		if len(contract_address) != 42:
		sys.exit('Malformed address')

		if constructor_args:
		cmd.extend(["--constructor-args", constructor_args])

	python -m scripts.verification.verify DssSpell 0xYourSpellAddress [constructorArgs]
	python -m scripts.verification.verify DssSpell 0x{spell_address}

	# Constants
	SOURCE_FILE_PATH = "src/DssSpell.sol"
	LIBRARY_NAME = "DssExecLib"

-def verify_contract_with_verifiers(
+def verify_contract_with_verifiers(
+    contract_name: str,
+    contract_address: str,
+    chain_id: str,
+    etherscan_api_key: str,
+) -> bool:

-        spell_success = verify_contract_with_verifiers(
+        spell_success = verify_contract_with_verifiers(
+            contract_name=spell_name,
+            contract_address=spell_address,
+            chain_id=chain_id,
+            etherscan_api_key=etherscan_api_key,
+        )

		retries = int(os.environ.get("VERIFY_RETRIES", "5"))
		delay = int(os.environ.get("VERIFY_DELAY", "5"))

Retry mechanism for verification in multiple explorers #487

Are you sure you want to change the base?

Retry mechanism for verification in multiple explorers #487

Uh oh!

Conversation

0xLaz3r commented Sep 1, 2025

Enhanced Contract Verification with Retry Mechanisms and Multi-Explorer Support

🎯 Summary

🔧 Key Changes

Retry Mechanisms

Multi-Explorer Support

Enhanced Error Handling

📝 Files Changed

⚙️ Usage (Unchanged)

✅ Benefits

🧪 Testing

🎯 Addresses Requirements

Uh oh!

DaiFoundation-DevOps commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

amusingaxl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

amusingaxl left a comment

Choose a reason for hiding this comment

Uh oh!

amusingaxl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

DaiFoundation-DevOps commented Sep 1, 2025 •

edited

Loading

coderabbitai bot commented Sep 1, 2025 •

edited

Loading