WIP influx packages #257
WIP influx packages #257
Conversation
favna
force-pushed
the
feat/influx-utilities/create
branch
from
fc2c576 to
31404a8
Compare
favna
dismissed
their stale review
Woops didn't mean to click approve because there are still merge conflicts
|
Other than that it needs manual testing this looks ready-ish? @kyranet |
|
@swiizyy when will you pick up the remaining TODOs? |
| } | ||
|
|
||
| export function initializeInflux(options: Client.Options = {}) { | ||
| if (!process.env.INFLUX_URL) return; |
There was a problem hiding this comment.
Also check whether INFLUX_ENABLED is true (envParseBoolean('INFLUX_ENABLED', true))
|
|
||
| protected initTags() { | ||
| this.tags.push( | ||
| [Tags.Client, envParseString('CLIENT_ID', Buffer.from(envParseString('DISCORD_TOKEN').split('.')[0], 'base64').toString())], |
There was a problem hiding this comment.
This always processes the fallback, it's better to do process.env.CLIENT_ID ?? Buffer.from(...).toString().
But at that point, does http-framework not provide a function for getting the client ID? o.o
There was a problem hiding this comment.
No, it doesn't seem to me, that's why I reused this... Do you want me to add this option to http-framework?
packages/shared-influx-pieces/src/lib/utils/ApproximateGuilds.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This entire README needs a rewrite, most of it is shared-http-pieces.
| @@ -1,3 +1,3 @@ | |||
| import { createTsupConfig } from '../../scripts/tsup.config'; | |||
|
|
|||
| export default createTsupConfig({ format: ['esm', 'cjs'] }); | |||
| export default createTsupConfig({ format: ['esm'] }); | |||
packages/shared-influx-pieces/src/listeners/influxAnalyticsSync.ts
Outdated
Show resolved
Hide resolved
packages/shared-influx-pieces/src/listeners/influxInteractionHandlerRun.ts
Outdated
Show resolved
Hide resolved
packages/shared-influx-pieces/src/listeners/influxInteractionHandlerRun.ts
Outdated
Show resolved
Hide resolved
packages/shared-influx-pieces/src/listeners/influxResourceAnalyticsSync.ts
Outdated
Show resolved
Hide resolved
packages/shared-influx-pieces/src/listeners/influxResourceAnalyticsSync.ts
Outdated
Show resolved
Hide resolved
Todos