This repository was archived by the owner on Aug 15, 2022. It is now read-only.
Implement passing configuration over environment variables #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request adds functionality for overriding configuration file content from environment variables.
For example:
This will result in effectively the following
rtmbot.conf
:All rtmbot-specific configuration variables can overridden. For plugin-specific configuration
I left the limitation of treating all values as strings to keep code from getting overly complex.
All this is mentioned in the
README.md
that is also updated by this pull request.Related Issues
Implements at least the environment variable portion of #89.
Test strategy
tests/test_rtmbot_runner.py
includes unit tests that cover most usual cases that came to mind.